Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] backfill preview modal - if an asset won't launch any partitions show a message instead of a spinner #26080

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[ui] backfill preview modal - if an asset won't launch any partitions show a message instead of a spinner #26080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions js_modules/dagster-ui/packages/ui-core/src/assets/BackfillPreviewModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const BackfillPreviewModal = ({
skip: !isOpen,
},
);
const {data} = queryResult;
const {data, loading} = queryResult;

const partitionsByAssetToken = useMemo(() => {
return Object.fromEntries(
Expand Down Expand Up @@ -107,8 +107,10 @@ export const BackfillPreviewModal = ({
<RowCell style={{color: Colors.textDefault(), alignItems: 'flex-start'}}>
{partitions ? (
<TargetPartitionsDisplay targetPartitions={partitions} />
) : (
) : loading ? (
<Spinner purpose="body-text" />
) : (
'No partitions available to materialize'
)}
</RowCell>
</RowGrid>
Expand Down
Loading