[ui] backfill preview modal - if an asset won't launch any partitions show a message instead of a spinner #26080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit ec8927d. |
jamiedemaria
commented
Nov 21, 2024
| loading ? ( | ||
| <Spinner purpose="body-text" /> | ||
| ) : ( | ||
| "No partitions available to materialize" |
There was a problem hiding this comment.
Alt options:
- No partitions in selected range
- No partitions in selected range available to materialize
- None
salazarm
approved these changes
Nov 21, 2024
jamiedemaria
force-pushed
the
jamie/empty-state-backfill-preview
branch
from
36ed114 to
0e409bf
Compare
jamiedemaria
force-pushed
the
jamie/empty-state-backfill-preview
branch
from
0e409bf to
ec8927d
Compare
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
… show a message instead of a spinner (dagster-io#26080) ## Summary & Motivation If you select a group of assets to backfill and select a range such that a subset of the assets have no partitions in that range, the Backfill Preview modal shows spinners for those assets For example - for the following asset graph <img width="743" alt="Screenshot 2024-11-21 at 11 46 09 AM" src="https://github.com/user-attachments/assets/08b3c5c5-9c32-417d-b2ea-4daaf716417d"> If you select only the latest hour to materialize, the daily asset will have no valid partitions to materialize (materializing today's asset isn't available until tomorrow) If you then click the "Backfill Preview" button, we show an infinite spinner for the daily asset  This PR adds a message when we know an asset wont have any partitions targeted by the backfill <img width="1113" alt="Screenshot 2024-11-21 at 11 41 39 AM" src="https://github.com/user-attachments/assets/6cbcd0d3-1444-4235-be7f-f229e9e41edc"> ## How I Tested These Changes ## Changelog [ui] Fixed a bug in the Backfill Preview where a loading spinner would spin forever if an asset had no valid partitions targeted by the backfill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
If you select a group of assets to backfill and select a range such that a subset of the assets have no partitions in that range, the Backfill Preview modal shows spinners for those assets
For example - for the following asset graph
If you select only the latest hour to materialize, the daily asset will have no valid partitions to materialize (materializing today's asset isn't available until tomorrow)
If you then click the "Backfill Preview" button, we show an infinite spinner for the daily asset
This PR adds a message when we know an asset wont have any partitions targeted by the backfill
How I Tested These Changes
Changelog
[ui] Fixed a bug in the Backfill Preview where a loading spinner would spin forever if an asset had no valid partitions targeted by the backfill