Implement AntlrRunSelectionVisitor on frontend #26243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 00b6923. |
briantu
force-pushed
the
briantu/add-run-selection-syntax-frontend
branch
from
30036c1 to
d9898b4
Compare
briantu
force-pushed
the
briantu/implement-run-selection-visitor
branch
from
0d8068c to
ca713a7
Compare
briantu
changed the base branch from
briantu/add-run-selection-syntax-frontend
to
graphite-base/26243
briantu
force-pushed
the
briantu/implement-run-selection-visitor
branch
from
ca713a7 to
00b6923
Compare
cmpadden
pushed a commit
that referenced
this pull request
Dec 5, 2024
## Summary & Motivation We now want to implement the visitor methods for `RunSelectionVisitor`. This requires having access to the metadata for each run to get the status. This is not available on type `GraphQueryItem`, so a new type `RunGraphQueryItem` was added to include the metadata. ## How I Tested These Changes `AntlrRunSelection.test.ts`
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
## Summary & Motivation We now want to implement the visitor methods for `RunSelectionVisitor`. This requires having access to the metadata for each run to get the status. This is not available on type `GraphQueryItem`, so a new type `RunGraphQueryItem` was added to include the metadata. ## How I Tested These Changes `AntlrRunSelection.test.ts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We now want to implement the visitor methods for
RunSelectionVisitor. This requires having access to the metadata for each run to get the status. This is not available on typeGraphQueryItem, so a new typeRunGraphQueryItemwas added to include the metadata.How I Tested These Changes
AntlrRunSelection.test.ts