Hook up run selection to GanttChart #26254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 3, 2024
briantu
force-pushed
the
briantu/implement-run-selection-visitor
branch
from
0d8068c to
ca713a7
Compare
briantu
force-pushed
the
briantu/hookup-antlr-run-selection
branch
from
00ae076 to
1f20dcf
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 2148558. |
salazarm
approved these changes
Dec 3, 2024
js_modules/dagster-ui/packages/ui-core/src/gantt/__fixtures__/dynamic.ts
Outdated
Show resolved
Hide resolved
briantu
force-pushed
the
briantu/hookup-antlr-run-selection
branch
from
1f20dcf to
bb918b8
Compare
briantu
changed the base branch from
briantu/implement-run-selection-visitor
to
graphite-base/26254
briantu
force-pushed
the
briantu/hookup-antlr-run-selection
branch
from
bb918b8 to
2148558
Compare
cmpadden
pushed a commit
that referenced
this pull request
Dec 5, 2024
## Summary & Motivation Hook up the run selection syntax to `GanttChart.tsx` and add feature flag for run selection syntax. ## How I Tested These Changes Existing tests should pass
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
## Summary & Motivation Hook up the run selection syntax to `GanttChart.tsx` and add feature flag for run selection syntax. ## How I Tested These Changes Existing tests should pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Hook up the run selection syntax to
GanttChart.tsxand add feature flag for run selection syntax.How I Tested These Changes
Existing tests should pass