Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] make reload button on RepositoryLocationErrorDialog optional #26282

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

benpankow
Copy link
Member

Summary

Used in https://github.com/dagster-io/internal/pull/12903 for cases where we're showing a historical error, not a current error (which might prompt a reload)

@benpankow
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@benpankow benpankow force-pushed the benpankow/optional-reload-err-dialog branch from c77a5d2 to 4e4ce93 Compare December 4, 2024 23:46
Copy link

github-actions bot commented Dec 4, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-4bdimql6i-elementl.vercel.app
https://benpankow-optional-reload-err-dialog.core-storybook.dagster-docs.io

Built with commit 4e4ce93.
This pull request is being automatically deployed with vercel-action

@dagster-io dagster-io deleted a comment from graphite-app bot Dec 4, 2024
@benpankow benpankow merged commit 0acea44 into master Dec 5, 2024
2 checks passed
@benpankow benpankow deleted the benpankow/optional-reload-err-dialog branch December 5, 2024 21:47
pskinnerthyme pushed a commit to pskinnerthyme/dagster that referenced this pull request Dec 16, 2024
…gster-io#26282)

## Summary

Used in https://github.com/dagster-io/internal/pull/12903 for cases
where we're showing a historical error, not a current error (which might
prompt a reload)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants