Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] make reload button on RepositoryLocationErrorDialog optional #26282

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[ui] make reload button on RepositoryLocationErrorDialog optional #26282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions js_modules/dagster-ui/packages/ui-core/src/workspace/RepositoryLocationErrorDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ interface Props {
error: PythonErrorFragment | {message: string} | null;
reloading: boolean;
onDismiss: () => void;
onTryReload: () => void;
onTryReload?: () => void;
}

export const RepositoryLocationErrorDialog = (props: Props) => {
Expand All @@ -27,9 +27,11 @@ export const RepositoryLocationErrorDialog = (props: Props) => {
<ErrorContents location={location} error={error} />
</DialogBody>
<DialogFooter>
<Button onClick={onTryReload} loading={reloading} intent="primary">
Reload again
</Button>
{onTryReload && (
<Button onClick={onTryReload} loading={reloading} intent="primary">
Reload again
</Button>
)}
<Button onClick={onDismiss}>Dismiss</Button>
</DialogFooter>
</Dialog>
Expand All @@ -50,9 +52,11 @@ export const RepositoryLocationNonBlockingErrorDialog = (props: Props) => {
<ErrorContents location={location} error={error} />
</DialogBody>
<DialogFooter>
<Button onClick={onTryReload} loading={reloading} intent="primary">
Reload
</Button>
{onTryReload && (
<Button onClick={onTryReload} loading={reloading} intent="primary">
Reload
</Button>
)}
<Button onClick={onDismiss}>Close</Button>
</DialogFooter>
</Dialog>
Expand Down
Loading