[Docs] Add tutorials category to integrations and reorganize integrations categories and sidebar #26323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikki everett <[email protected]>
|
@neverett looks like we're getting a couple errors in Vercel: |
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
|
@cmpadden those errors should be fixed now, mind taking another look? |
cmpadden
reviewed
Dec 10, 2024
docs/docs-beta/sidebars.ts
Outdated
| { | ||
| type: 'category', | ||
| label: 'Alerting', | ||
| label: 'Dagster-supported', |
There was a problem hiding this comment.
What do you think about making Dagster-supported the default, so it's at the top level, and then community supported being a sub folder? I think that might reduce the visual clutter slightly.
There was a problem hiding this comment.
And then we can create some cool React components to have tags on the integration pages themselves with dagster verified or something along those lines.
There was a problem hiding this comment.
I think that's a great idea! Looks like Docusaurus has tagging built in, so I just used that. All integrations libraries now live in the "Libraries" section and have relevant tags (dagster-supported, community-supported, ETL, etc); tags are at the bottom of the page.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
|
@neverett here are the Vercel errors for easier reference: |
cmpadden
approved these changes
Dec 12, 2024
Ugh, sorry, I should've waited for the build to finish before commenting -- I'll fix those. Also cc @dehume -- here's more docs revamp work, if you're curious |
Signed-off-by: nikki everett <[email protected]>
docs/docs-beta/docs/dagster-plus/deployment/hybrid/agents/kubernetes.md
Outdated
Show resolved
Hide resolved
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…ions categories and sidebar (dagster-io#26323) ## Summary & Motivation * Add "Tutorials" category to "Integrations" * Reorganize categories for integrations libraries -- we now have "Dagster supported" and "Community supported". ## How I Tested These Changes Tested locally ## Changelog > Insert changelog entry or delete this section. --------- Signed-off-by: nikki everett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Tested locally
Changelog