Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sql syntax highlighting to dbt asset descriptions #26393

Conversation

anuthebananu
Copy link
Contributor

Summary & Motivation

Adds SQL syntax highlighting to raw sql code in dbt asset descriptions. Only for dbt assets, when the dbt asset exposes the raw sql.

How I Tested These Changes

Spun up the sample dbt project and navigated to a dbt asset. The sql code in the description has syntax highlighting.

Light mode:
image

Dark mode:
image

@salazarm we had discussed using custom CSS to make the blue text stand out more in dark mode, but it appears to be fairly readable in my browser. Let me know if you feel we still need custom CSS here.

Changelog

Not sure if this needs a changelog? I can add one if necessary.

@salazarm
Copy link
Contributor

I think we should overwrite the colors to use our themed colors because on my screen I can barely make out the blue text in dark mode.

Copy link
Contributor Author

anuthebananu commented Dec 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@anuthebananu anuthebananu marked this pull request as draft December 16, 2024 18:40
@anuthebananu anuthebananu force-pushed the anurag/oper-1526-add-sql-syntax-highlighting-to-dbt-asset-details-page branch from b7bc24f to 0ea2f81 Compare December 16, 2024 21:52
@anuthebananu anuthebananu marked this pull request as ready for review December 16, 2024 21:53
@anuthebananu anuthebananu force-pushed the anurag/oper-1526-add-sql-syntax-highlighting-to-dbt-asset-details-page branch from 0ea2f81 to 8d283bb Compare December 17, 2024 20:35
@anuthebananu anuthebananu added the area: UI/UX Related to User Interface and User Experience label Dec 17, 2024 — with Graphite App
@anuthebananu anuthebananu force-pushed the anurag/oper-1526-add-sql-syntax-highlighting-to-dbt-asset-details-page branch from 8d283bb to 940d8ff Compare December 17, 2024 21:03
Copy link
Contributor Author

anuthebananu commented Dec 17, 2024

Merge activity

  • Dec 17, 4:19 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 17, 4:20 PM EST: A user merged this pull request with Graphite.

@anuthebananu anuthebananu merged commit 1ca47d0 into master Dec 17, 2024
1 check was pending
@anuthebananu anuthebananu deleted the anurag/oper-1526-add-sql-syntax-highlighting-to-dbt-asset-details-page branch December 17, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI/UX Related to User Interface and User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants