Add custom colors to markdown code block for syntax highlighting #26554
+41
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
anuthebananu
changed the title
anuthebananu
added
the
area: UI/UX
Graphite App
salazarm
reviewed
Dec 17, 2024
js_modules/dagster-ui/packages/ui-core/src/ui/MarkdownWithPlugins.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Dec 17, 2024
js_modules/dagster-ui/packages/ui-core/src/ui/MarkdownWithPlugins.tsx
Outdated
Show resolved
Hide resolved
|
looks like you need to run lint to format your changes |
|
weird. i would have expected lint to run in my local repo pre-commit. |
|
I don't think our pre-commit hook runs lint. |
anuthebananu
force-pushed
the
anurag/oper-1526-add-sql-syntax-highlighting-to-dbt-asset-details-page
branch
from
8d283bb to
940d8ff
Compare
anuthebananu
force-pushed
the
12-17-add_custom_colors_to_markdown_code_block_for_syntax_highlighting
branch
from
4bd9abe to
f474466
Compare
|
Ah well that would explain it then. Per |
anuthebananu
force-pushed
the
12-17-add_custom_colors_to_markdown_code_block_for_syntax_highlighting
branch
from
f474466 to
7ac235f
Compare
|
No reason. We could probably add it, but generally I have eslint auto-format my files on save so I don't need the pre-commit hook but I'm guessing you don't have eslint configured in vscode to do this automatically. |
salazarm
reviewed
Dec 17, 2024
anuthebananu
changed the base branch from
anurag/oper-1526-add-sql-syntax-highlighting-to-dbt-asset-details-page
to
graphite-base/26554
anuthebananu
force-pushed
the
12-17-add_custom_colors_to_markdown_code_block_for_syntax_highlighting
branch
from
2402f9c to
9125a5f
Compare
anuthebananu
deleted the
12-17-add_custom_colors_to_markdown_code_block_for_syntax_highlighting
branch
neilfulwiler
pushed a commit
that referenced
this pull request
Dec 19, 2024
) ## Summary & Motivation Default syntax highlighting colors from `highlight.js` were not always clearly visible in dark mode. Adding our custom colors improves the contrast and ensures we'll always have good contrast in light and dark mode. ## How I Tested These Changes run `dagster dev` on the sample dbt project and look at dbt asset descriptions. Below are screenshots of various sql code blocks from the dbt asset descriptions, illustrating the new colors in light and dark mode.       ## Changelog > Insert changelog entry or delete this section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Default syntax highlighting colors from
highlight.jswere not always clearly visible in dark mode. Adding our custom colors improves the contrast and ensures we'll always have good contrast in light and dark mode.How I Tested These Changes
run
dagster devon the sample dbt project and look at dbt asset descriptions.Below are screenshots of various sql code blocks from the dbt asset descriptions, illustrating the new colors in light and dark mode.
Changelog