[azure-docs] refine deployment with ACR docs #26397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-6up78ds5f-elementl.vercel.app Direct link to changed pages: |
mlarose
force-pushed
the
mlarose/dogfood-azure-docs
branch
from
deca5e4 to
6875473
Compare
dpeng817
approved these changes
Dec 11, 2024
mlarose
force-pushed
the
mlarose/dogfood-azure-docs
branch
from
d6e677f to
ba9f895
Compare
neverett
approved these changes
Dec 12, 2024
mlarose
force-pushed
the
mlarose/dogfood-azure-docs
branch
from
ba9f895 to
b8cb7dd
Compare
Additions and modifications noted from dogfooding the guide
mlarose
force-pushed
the
mlarose/dogfood-azure-docs
branch
from
b8cb7dd to
22311e0
Compare
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
## Summary & Motivation Updates the Azure Container Registry (ACR) user code documentation with missing instructions for configuring GitHub Actions and Dagster Cloud. Adds detailed steps for setting up environment variables, updating other step of the CI/CD workflow, and configuring the `dagster_cloud.yaml` file to work with ACR. ## How I Tested These Changes - All changes are resulting from reproducing and fixing omissions in the previous version. ## Changelog - NOCHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Updates the Azure Container Registry (ACR) user code documentation with missing instructions for configuring GitHub Actions and Dagster Cloud. Adds detailed steps for setting up environment variables, updating other step of the CI/CD workflow, and configuring the
dagster_cloud.yamlfile to work with ACR.How I Tested These Changes
Changelog