-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azure-docs] refine AzureBlobComputeLogManager guide #26407
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7196119
to
88b4cfc
Compare
docs/content/dagster-plus/deployment/azure/blob-compute-logs.mdx
Outdated
Show resolved
Hide resolved
88b4cfc
to
ef09253
Compare
docs/content/dagster-plus/deployment/azure/blob-compute-logs.mdx
Outdated
Show resolved
Hide resolved
docs/content/dagster-plus/deployment/azure/blob-compute-logs.mdx
Outdated
Show resolved
Hide resolved
docs/content/dagster-plus/deployment/azure/blob-compute-logs.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff, man. I think this is all super valuable and thanks again for dogfooding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments that you can apply as you see fit, but overall this looks good to me. I'll go ahead and approve so you're not blocked on merging this.
docs/content/dagster-plus/deployment/azure/blob-compute-logs.mdx
Outdated
Show resolved
Hide resolved
docs/content/dagster-plus/deployment/azure/blob-compute-logs.mdx
Outdated
Show resolved
Hide resolved
docs/content/dagster-plus/deployment/azure/blob-compute-logs.mdx
Outdated
Show resolved
Hide resolved
docs/content/dagster-plus/deployment/azure/blob-compute-logs.mdx
Outdated
Show resolved
Hide resolved
docs/content/dagster-plus/deployment/azure/blob-compute-logs.mdx
Outdated
Show resolved
Hide resolved
docs/content/dagster-plus/deployment/azure/blob-compute-logs.mdx
Outdated
Show resolved
Hide resolved
ba9f895
to
b8cb7dd
Compare
ef09253
to
86bb9fd
Compare
Thanks Nikki, I appreciate the feedback! |
Additions and modifications noted from dogfooding the guide
86bb9fd
to
ff175a8
Compare
## Summary & Motivation Updates the Azure Blob Storage compute logs documentation to clarify the setup process and fix issues with workload identity configuration. Adds specific instructions for using the Dagster+ Helm chart and includes a new "Next steps" section in the ACR user code guide. ## How I Tested These Changes - Verified all commands and configurations work in an Azure Kubernetes Service (AKS) environment ## Changelog - NOCHANGELOG
Summary & Motivation
Updates the Azure Blob Storage compute logs documentation to clarify the setup process and fix issues with workload identity configuration. Adds specific instructions for using the Dagster+ Helm chart and includes a new "Next steps" section in the ACR user code guide.
How I Tested These Changes
Changelog