Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-docs] refine AzureBlobComputeLogManager guide #26407

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mlarose
Copy link
Contributor

@mlarose mlarose commented Dec 11, 2024

Summary & Motivation

Updates the Azure Blob Storage compute logs documentation to clarify the setup process and fix issues with workload identity configuration. Adds specific instructions for using the Dagster+ Helm chart and includes a new "Next steps" section in the ACR user code guide.

How I Tested These Changes

  • Verified all commands and configurations work in an Azure Kubernetes Service (AKS) environment

Changelog

  • NOCHANGELOG

Copy link
Contributor Author

mlarose commented Dec 11, 2024

@mlarose mlarose force-pushed the mlarose/dogfood-azure-blob-storage-logs-docs branch from 7196119 to 88b4cfc Compare December 11, 2024 18:33
@mlarose mlarose force-pushed the mlarose/dogfood-azure-blob-storage-logs-docs branch from 88b4cfc to ef09253 Compare December 11, 2024 18:43
@mlarose mlarose marked this pull request as ready for review December 11, 2024 18:46
@mlarose mlarose requested a review from neverett as a code owner December 11, 2024 18:46
@mlarose mlarose requested a review from dpeng817 December 11, 2024 18:46
Copy link
Contributor

@dpeng817 dpeng817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, man. I think this is all super valuable and thanks again for dogfooding.

@neverett neverett added the docs-to-migrate Docs to migrate to new docs site label Dec 12, 2024
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments that you can apply as you see fit, but overall this looks good to me. I'll go ahead and approve so you're not blocked on merging this.

@mlarose mlarose force-pushed the mlarose/dogfood-azure-docs branch from ba9f895 to b8cb7dd Compare December 12, 2024 19:09
@mlarose mlarose force-pushed the mlarose/dogfood-azure-blob-storage-logs-docs branch from ef09253 to 86bb9fd Compare December 12, 2024 19:09
Copy link
Contributor Author

mlarose commented Dec 12, 2024

Thanks Nikki, I appreciate the feedback!

Copy link
Contributor Author

mlarose commented Dec 12, 2024

Merge activity

  • Dec 12, 2:10 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 12, 2:16 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 12, 2:17 PM EST: A user merged this pull request with Graphite.

@mlarose mlarose changed the base branch from mlarose/dogfood-azure-docs to graphite-base/26407 December 12, 2024 19:11
@mlarose mlarose changed the base branch from graphite-base/26407 to master December 12, 2024 19:13
Additions and modifications noted from dogfooding the guide
@mlarose mlarose force-pushed the mlarose/dogfood-azure-blob-storage-logs-docs branch from 86bb9fd to ff175a8 Compare December 12, 2024 19:15
@mlarose mlarose merged commit 9e60148 into master Dec 12, 2024
1 of 2 checks passed
@mlarose mlarose deleted the mlarose/dogfood-azure-blob-storage-logs-docs branch December 12, 2024 19:17
pskinnerthyme pushed a commit to pskinnerthyme/dagster that referenced this pull request Dec 16, 2024
## Summary & Motivation

Updates the Azure Blob Storage compute logs documentation to clarify the setup process and fix issues with workload identity configuration. Adds specific instructions for using the Dagster+ Helm chart and includes a new "Next steps" section in the ACR user code guide.

## How I Tested These Changes

- Verified all commands and configurations work in an Azure Kubernetes Service (AKS) environment

## Changelog

- NOCHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-to-migrate Docs to migrate to new docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants