-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial powerbi assets #127
Conversation
Your pull request at commit
|
Your pull request at commit
|
Your pull request at commit
|
Your pull request at commit
|
Your pull request at commit
|
Your pull request at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! So excited to have it in, thanks for chasing all of this down
Is this something we want to merge or just an example to keep around as a branch deployment?
Deploy
Is there a "flow" that tells the story better than "analysis of augmented orders"
lgtm
Should the group be "BI" or tied to some business area?
BI is my preference
I left a few other comments. My other request, if possible, can we add a link to the dashboard in the asset description? I don't want to have to remember how to get to it, and I think it adds some pizzaz to an otherwise empty asset card/overview page
hooli_data_eng/resources/__init__.py
Outdated
@@ -58,6 +59,7 @@ | |||
|
|||
resource_def = { | |||
"LOCAL": { | |||
"power_bi": power_bi_workspace, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is something we can do here to mock it out so folks who clone and run this locally without the powerBI creds still work?
(Speaking as someone who will want to be able to run the demo locally without worrying if I have sourced the power BI creds correctly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That 100% makes sense -- I'll look into mocking it, I guess the only question is if we want to mock the power bi assets locally, I'd lean towards leaving it all off from local dev if possible, but I'm not exactly sure how that would work. Maybe @benpankow you have some ideas?
Just to confirm, by "deploy" you mean merge into master post comment addressing? |
Co-authored-by: Sean Lopp <[email protected]>
Your pull request at commit
|
Your pull request at commit
|
Your pull request at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐐
Your pull request at commit
|
Your pull request at commit
|
Your pull request at commit
|
Your pull request at commit
|
Your pull request at commit
|
Your pull request at commit
|
This PR adds Power BI assets to the Hooli project. Features include:
Open Questions:
See below for a screenshot of what it looks like