Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial powerbi assets #127
add initial powerbi assets #127
Changes from 6 commits
976f5d4
0a0b179
c55a2ed
3b876cf
f59360f
4c51d6c
759ed53
25a3319
a2908f2
cd1b656
a9698c0
7b3fc75
92bdcb3
1969cda
5d67217
906680b
9790d8e
6041696
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is something we can do here to mock it out so folks who clone and run this locally without the powerBI creds still work?
(Speaking as someone who will want to be able to run the demo locally without worrying if I have sourced the power BI creds correctly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That 100% makes sense -- I'll look into mocking it, I guess the only question is if we want to mock the power bi assets locally, I'd lean towards leaving it all off from local dev if possible, but I'm not exactly sure how that would work. Maybe @benpankow you have some ideas?