ENH: Test tools for jax.jit and dask #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
changed the title
crusaderky
commented
Jan 21, 2025
crusaderky
commented
Jan 21, 2025
| lazy_xp_function(kron, static_argnames="xp") | ||
| lazy_xp_function(nunique, static_argnames="xp") | ||
| lazy_xp_function(pad, static_argnames=("pad_width", "mode", "constant_values", "xp")) | ||
| # FIXME calls in1d which calls xp.unique_values without size |
There was a problem hiding this comment.
This is non-trivial to fix. Will look into it in a follow-up.
crusaderky
force-pushed
the
test_jit
branch
5 times, most recently
from
57e6cd0 to
cd84a8b
Compare
crusaderky
force-pushed
the
test_jit
branch
2 times, most recently
from
64ba88b to
47ef8b5
Compare
crusaderky
commented
Jan 22, 2025
This was referenced Jan 22, 2025
lucascolley
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
thanks @crusaderky, LGTM! I don't have much to say on the details of how this interfaces with JAX and Dask, but it all sounds reasonable to me, and the code looks maintainable.
|
@lucascolley all comments addressed |
lucascolley
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting of scipy/scipy#22308, with additional support for Dask.