-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: XHR Transport and Fetch Transport for React Native support (among others) #348
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution @fundthmcalculus! I will happily merge the PR once the tests turn green. Please ping me if you need any assistance. Mind the flaky tests with traefik though. Ignore errors like in this run: https://github.com/deeplay-io/nice-grpc/actions/runs/4736697563/jobs/8409567422 |
Thanks for the quick feedback! I've actually got another change I'm going to bring into this PR which will enable fetch APIs when you don't have file reader support on react native. |
@aikoven if you could take a look as to why the tests are failing, I'd really appreciate it. |
The NodeJS tests fail because of this error:
The browser tests are hanging for some reason. You can try running them locally using
from the |
@fundthmcalculus What's the status of this PR? Can you please fix the failing tests? It would be nice to use it in our app, because grpc support in react native isn't really supported. |
I patched it manually locally and it works in my expo app. You could try that @hollanderbart |
After spending several days working on react native for grpc, I was able to adapt the @improbable-end/grpc-web-react-native-transport to work with
nice-grpc-web
. This enables support for grpc web in react native where websockets are not supported.Also, added support for
fetch
api in cases wherearrayBuffer()
is not supported.blob()
mode is supported, but only in a base64 format. Hence the optionalblobMode
configuration parameter.