Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chartmark.md #4

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Update chartmark.md #4

wants to merge 3 commits into from

Conversation

basicthinker
Copy link
Contributor

No description provided.

@basicthinker basicthinker requested a review from kagami-l January 3, 2024 17:27
@basicthinker basicthinker self-assigned this Jan 3, 2024
@basicthinker basicthinker added the enhancement New feature or request label Jan 3, 2024
@basicthinker basicthinker requested a review from runjinz January 3, 2024 17:28
kagami-l
kagami-l approved these changes Jan 4, 2024
View reviewed changes
Copy link

@kagami-l kagami-l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

实现更新的顺序需要注意：

  1. 首先 @runjinz 更新前端实现，提交 PR 后暂不合并，告知 @kagami-l
  2. 然后 @kagami-l 更新workflow里的python封装，调试后提交PR
  3. 1&2中的PR都Ready后同时合并，并更新插件

@kagami-l kagami-l mentioned this pull request Jan 5, 2024
Merged
runjinz
runjinz reviewed Jan 5, 2024
View reviewed changes
docs/specs/chatmark.md
```yaml
file1: checked
file2: checked
form: submitted
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是否有些冗余？上边的数据就是表单来的，如果没有提交就有cancel的信息出现了。
另外，似乎没有看到cancel的示例，不知道哦啊用户能不能猜到则呢用。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runjinz runjinz runjinz left review comments

@kagami-l kagami-l kagami-l approved these changes

Assignees

@basicthinker basicthinker

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basicthinker @runjinz @kagami-l