Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] CI: Add extra Phobos tests (publictests and betterc make targets) #17107

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Dec 6, 2024

Adopting https://github.com/dlang/phobos/blob/9e7d2f37cfd36f42b7f2376ad07814297e40809f/.circleci/run.sh#L122-L133 to catch any compiler-caused regressions here for DMD CI, instead of breaking Phobos CI after the DMD merge.

After merging this, the Phobos GitHub Actions workflow will newly include these tests as well.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#17107"

@kinke
Copy link
Contributor Author

kinke commented Dec 6, 2024

@dkorpel: This shows that #15343 (totally unexpectedly) broke Phobos CI, which runs some extra tests (in some CI jobs only, and on Linux only), that weren't tested here for DMD, and only those publictests now fail with undefined lambda symbols. Reverting the mangle/identifier change makes them pass again.

I've seen similar undefined-lambda-symbol regressions for a Symmetry codebase with LDC v1.40.0-beta5, which includes that mangling change from DMD stable. Beta4 was fine and there weren't any huge other changes that are likely to have caused those regressions.

@kinke kinke force-pushed the ci_add_extra_phobos_tests branch from 06a3ba9 to 1e95afa Compare December 7, 2024 15:16
@kinke kinke marked this pull request as ready for review December 7, 2024 15:34
@dlang-bot dlang-bot merged commit 587a634 into dlang:stable Dec 8, 2024
73 checks passed
@kinke kinke deleted the ci_add_extra_phobos_tests branch December 8, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants