Support launching net taskhost - initial implementation #11393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
force-pushed
the
dev/ykovalova/support_launching_net_taskhost
branch
from
2d1cd86 to
9b892e9
Compare
baronfel
reviewed
Feb 12, 2025
src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcTaskHost.cs
Outdated
Show resolved
Hide resolved
src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcTaskHost.cs
Outdated
Show resolved
Hide resolved
| { | ||
| // Start the new process. We pass in a node mode with a node number of 2, to indicate that we | ||
| // want to start up an MSBuild task host node. | ||
| commandLineArgs = $"/nologo /nodemode:2 /nodereuse:{ComponentHost.BuildParameters.EnableNodeReuse} /low:{ComponentHost.BuildParameters.LowPriority}"; |
There was a problem hiding this comment.
the rest of these arguments (node reuse/priority) should be applied to the .NET-host command line too, right?
There was a problem hiding this comment.
not sure
@rainersigwald could you clarify this point, please?
YuliiaKovalova
commented
Feb 14, 2025
| if (!string.IsNullOrWhiteSpace(realTaskAssemblyLoaction) && | ||
| realTaskAssemblyLoaction != _taskFactoryWrapper.TaskFactoryLoadedType.Path) | ||
| // TODO ask why for net task host it returns false net472\MSBuild\Current\Bin\Microsoft.Build.dll instead of path to a custom task. | ||
| // Interestingly TaskInstance._taskType contains the correct path. |
There was a problem hiding this comment.
@rainersigwald , it's a question for you when you will review :)
YuliiaKovalova
changed the title
YuliiaKovalova
force-pushed
the
dev/ykovalova/support_launching_net_taskhost
branch
from
ad14fb9 to
65691df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #11331
To test the feature, setup these env variables:
MSBuildToolsDirectoryNET= e.g. "C:\msbuild\msbuild_yk\msbuild\artifacts\bin\bootstrap\core"MSBuildAssemblyDirectory= e.g. "C:\msbuild\msbuild_yk\msbuild\artifacts\bin\bootstrap\core\sdk\9.0.200-preview.0.24603.3"Keep in mind, due to current handshake mechanism, only matching version of sdk can be launched.
The tests are commented because we don't expect them to run now for NET runtime. There is a separate task to cover this functionality.