Skip to content

Make the dotnet/runtime official build an assetless build #115311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented May 5, 2025

Make assetless publishing run in parallel with the Build stage of the official build.

I've moved jobs to the runtime-codeql pipeline (and made that an official pipeline) to ensure that we still have coverage for SDL tools on dotnet/runtime code (per the current VMR plan to have each repo handle their SDL compliance initially).

Also remove the infrastructure around the join job in dotnet/runtime.

Depends on us making the final decision to go with the VMR (and being comfortable removing old infra).

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2702458&view=results

…rastructure needed to publish from dotnet/runtime
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@jkoritzinsky jkoritzinsky added this to the 10.0.0 milestone May 5, 2025
@jkoritzinsky jkoritzinsky added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 5, 2025
@jkoritzinsky jkoritzinsky marked this pull request as ready for review May 5, 2025 19:56
@Copilot Copilot AI review requested due to automatic review settings May 5, 2025 19:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enables assetless publishing to run in parallel with the Build stage for the dotnet/runtime official build while removing the infrastructure around the join job.

  • Updated the pipeline template reference to use a common pipeline template with resources.
  • Added a new Publish stage with assetless build parameters.
Files not reviewed (5)
  • Build.proj: Language not supported
  • eng/Publishing.props: Language not supported
  • eng/Signing.props: Language not supported
  • eng/pipelines/official/pipeline.yml: Language not supported
  • eng/pipelines/official/prepare-signed-artifacts.yml: Language not supported
Comments suppressed due to low confidence (2)

eng/pipelines/runtime-official.yml:33

  • Consider reviewing the use of multiple extends templates to ensure that there is no parameter conflict or ambiguity between the official and common pipeline templates.
template:  /eng/pipelines/common/templates/pipeline-with-resources.yml

eng/pipelines/runtime-official.yml:167

  • Verify that the pool selection and demand criteria match the requirements for assetless builds, ensuring the correct agent is used.
demands: ImageOverride -equals 1es-windows-2022

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one comment. Post merge, CG will need to be reconfigured to now analyze the codeql pipeline instead. cc @ericstj for awareness

@ericstj
Copy link
Member

ericstj commented May 6, 2025

@jkoritzinsky can you show me a CodeQL build that's running all the tools appropriately? Let's make sure that's set up correctly, or we have bugs on any issues before we merge this.

As for CG - that doesn't require assets and can stay running on official build if it "builds the most". I'm not sure how much CodeQL builds so it's unclear if that's the right place for those other tools or not. Let's consider case-by-case. It also might be good to add a doc that records these decisions as intentional.

@jkoritzinsky
Copy link
Member Author

@jkoritzinsky
Copy link
Member Author

@jkoritzinsky
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants