Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure and improve the docs #679

Merged
merged 22 commits into from
Nov 20, 2024
Merged

Restructure and improve the docs #679

merged 22 commits into from
Nov 20, 2024

Conversation

andreaTP
Copy link
Collaborator

Supersede #675 opening the PR in the main repo to (hopefully) get the Cloudflare preview.

Copy link

cloudflare-workers-and-pages bot commented Nov 19, 2024

Deploying chicory with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0f8c167
Status: ✅  Deploy successful!
Preview URL: https://5d761d76.chicory.pages.dev
Branch Preview URL: https://docs-revamp.chicory.pages.dev

View logs

@andreaTP
Copy link
Collaborator Author

cc. @kanatohodets please feel free to review the new structure.

On top of this, either you look for gaps yourself(there are for sure) or, I would go for the examples: #667

For TinyGo I think this PR is the best "getting started".

docs/docs/experimental/1-why.md Outdated Show resolved Hide resolved
docs/docs/experimental/1-why.md Outdated Show resolved Hide resolved
docs/docs/experimental/4-cli.md Outdated Show resolved Hide resolved
docs/docs/index.md Outdated Show resolved Hide resolved
docs/docs/usage/1-memory.md Outdated Show resolved Hide resolved

## Pre-compiled AOT

You can use the AOT compiler at build-time, by leveraging a [Maven plug-in][aot-maven-plugin] to overcome the usage of reflection and external dependencies of the "Runtime AOT".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aot-maven-plugin link doesn't work (no suggestion since I'm not sure what you intended)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's name this file host-module-annotations or just host-modules. The abbreviation looks strange.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

docs/docs/experimental/3-aot.md Outdated Show resolved Hide resolved

#### IDE shortcomings

In some IDEs the sources generated under the standard folder `target/generated-sources` are not automatically recognized.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which IDEs? This works correctly in IntelliJ.

There are sometimes issues with needing to force refresh or ignore/uniginore the modules when doing development of Chicory itself after switching branches/etc., but this shouldn't be a problem for normal users of Chicory.

Even when developing Chicory, the generates-sources/chicory-aot directory gets registered automatically for me in the wabt module, once everything "stabilizes".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a known issue in VSCode and Eclipse, I added the note as I've been requested a fix a few times here and in various other projects.

It's unnecessary, but doesn't hurt either in IntelliJ.

docs/docs/experimental/3-aot.md Outdated Show resolved Hide resolved
andreaTP and others added 21 commits November 20, 2024 11:18
Co-authored-by: David Phillips <[email protected]>
Co-authored-by: David Phillips <[email protected]>
Co-authored-by: David Phillips <[email protected]>
Co-authored-by: David Phillips <[email protected]>
Co-authored-by: David Phillips <[email protected]>
@andreaTP andreaTP merged commit c6737a6 into main Nov 20, 2024
25 checks passed
@andreaTP andreaTP deleted the docs-revamp branch November 20, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants