Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure and improve the docs #679
Restructure and improve the docs #679
Changes from 1 commit
118ccf1
9068050
aeaeab2
a09dba5
70ee2f1
cd68b05
4c76c93
f48335c
c8e114b
7fb2bd3
b7888f1
8e53bd8
8462e83
98f169c
6179781
433c205
ec78c1d
cb55a51
a78ab1d
d70e7c3
945556b
0f8c167
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's name this file
host-module-annotations
or justhost-modules
. The abbreviation looks strange.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
aot-maven-plugin
link doesn't work (no suggestion since I'm not sure what you intended)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which IDEs? This works correctly in IntelliJ.
There are sometimes issues with needing to force refresh or ignore/uniginore the modules when doing development of Chicory itself after switching branches/etc., but this shouldn't be a problem for normal users of Chicory.
Even when developing Chicory, the
generates-sources/chicory-aot
directory gets registered automatically for me in thewabt
module, once everything "stabilizes".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a known issue in VSCode and Eclipse, I added the note as I've been requested a fix a few times here and in various other projects.
It's unnecessary, but doesn't hurt either in IntelliJ.