Remove unnecessary done() call on ProgressMonitor #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogella
force-pushed
the
more_submonitor_calls
branch
from
ec6c163 to
5c48af9
Compare
|
@ptziegler please have a quick look. |
ptziegler
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
CompositeArtifactRepository is calling done() on the SubMonitor, so that should be fine as well and CompositeArtifactRepositoryFactory is also only actively using the SubMonitor, making it the responsibility of the callert to call done(). This should then also be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html