Replaced deprecated count() method #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unckleg
suggested changes
Dec 18, 2018
| @@ -51,7 +51,7 @@ function paginate(query, options, callback) { | |||
| } | |||
| promises = { | |||
| docs: docsQuery.exec(), | |||
| count: this.count(query).exec() | |||
There was a problem hiding this comment.
When using countable querying you should use @estimatedDocumentCount as discussed in: Automattic/mongoose#6713.
| @@ -66,15 +66,15 @@ function paginate(query, options, callback) { | |||
| return Promise.all(promises).then((data) => { | |||
| let result = { | |||
| docs: data.docs, | |||
| total: data.count, | |||
There was a problem hiding this comment.
This should stay as is (data.count). Because property count is result of @estimatedDocumentCount method.
| limit: limit | ||
| }; | ||
| if (offset !== undefined) { | ||
| result.offset = offset; | ||
| } | ||
| if (page !== undefined) { | ||
| result.page = page; | ||
| result.pages = Math.ceil(data.count / limit) || 1; |
There was a problem hiding this comment.
This should stay as is (data.count). Because property count is result of @estimatedDocumentCount method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.