Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated count() method #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replaced deprecated count() method #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function paginate(query, options, callback) {
}
promises = {
docs: docsQuery.exec(),
count: this.count(query).exec()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using countable querying you should use @estimatedDocumentCount as discussed in: Automattic/mongoose#6713.

count: this.countDocuments(query).exec()
};
if (lean && leanWithId) {
promises.docs = promises.docs.then((docs) => {
Expand All @@ -66,15 +66,15 @@ function paginate(query, options, callback) {
return Promise.all(promises).then((data) => {
let result = {
docs: data.docs,
total: data.count,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay as is (data.count). Because property count is result of @estimatedDocumentCount method.

total: data.countDocuments,
limit: limit
};
if (offset !== undefined) {
result.offset = offset;
}
if (page !== undefined) {
result.page = page;
result.pages = Math.ceil(data.count / limit) || 1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay as is (data.count). Because property count is result of @estimatedDocumentCount method.

result.pages = Math.ceil(data.countDocuments / limit) || 1;
}
if (typeof callback === 'function') {
return callback(null, result);
Expand Down