Skip to content

Add missing capabilities #124625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2025
Merged

Add missing capabilities #124625

merged 4 commits into from
Mar 12, 2025

Conversation

idegtiarenko
Copy link
Contributor

@idegtiarenko idegtiarenko commented Mar 12, 2025

The tests failed for older versions.
This change declares required capabilities so that versions without them could be skipped

Related to: #123381
Closes: #124614

@idegtiarenko idegtiarenko added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL v9.1.0 labels Mar 12, 2025
@idegtiarenko idegtiarenko requested a review from ivancea March 12, 2025 07:58
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Comment on lines +1275 to +1276
warningRegex: evaluation of \[ends_with\(description, \\\"host\\\"\)\] failed, treating result as null. Only first 20 failures recorded.
warningRegex: java.lang.IllegalArgumentException: single-value function encountered multi-value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also make this change in startsWithLucenePushdownIgnoreMultivalues, which is the same but with StartsWith. If one ails, the other probably fails too

@idegtiarenko idegtiarenko merged commit 79e776a into elastic:main Mar 12, 2025
17 checks passed
@idegtiarenko idegtiarenko deleted the fix_tests branch March 12, 2025 12:28
@idegtiarenko idegtiarenko added auto-backport Automatically create backport pull requests when merged and removed backport labels Mar 12, 2025
idegtiarenko added a commit to idegtiarenko/elasticsearch that referenced this pull request Mar 12, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 12, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 12, 2025
albertzaharovits pushed a commit to albertzaharovits/elasticsearch that referenced this pull request Mar 13, 2025
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Mar 13, 2025
ivancea pushed a commit to ivancea/elasticsearch that referenced this pull request Mar 14, 2025
ivancea added a commit that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.19.0 v9.0.1 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] MixedClusterEsqlSpecIT test {string.EndsWithLucenePushdownIgnoreMultivalues SYNC} failing
3 participants