Skip to content

Add missing capabilities #124625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2025
Merged

Add missing capabilities #124625

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
286b1bf
Add missing capabilities
idegtiarenko Mar 12, 2025
5f3542d
fix list
idegtiarenko Mar 12, 2025
38f7bf3
skip line checks
idegtiarenko Mar 12, 2025
9cfa1e9
upd
idegtiarenko Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/string.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,8 +987,8 @@ from hosts
| keep description
| sort description;

warning:Line 2:9: evaluation of [starts_with(description, \"epsilon\")] failed, treating result as null. Only first 20 failures recorded.
warning:Line 2:9: java.lang.IllegalArgumentException: single-value function encountered multi-value
warningRegex: evaluation of \[starts_with\(description, \\\"epsilon\\\"\)\] failed, treating result as null. Only first 20 failures recorded.
warningRegex: java.lang.IllegalArgumentException: single-value function encountered multi-value

description:text
epsilon gw instance
Expand Down Expand Up @@ -1272,8 +1272,8 @@ from hosts
| keep description
| sort description;

warning:Line 2:9: evaluation of [ends_with(description, \"host\")] failed, treating result as null. Only first 20 failures recorded.
warning:Line 2:9: java.lang.IllegalArgumentException: single-value function encountered multi-value
warningRegex: evaluation of \[ends_with\(description, \\\"host\\\"\)\] failed, treating result as null. Only first 20 failures recorded.
warningRegex: java.lang.IllegalArgumentException: single-value function encountered multi-value
Comment on lines +1275 to +1276
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also make this change in startsWithLucenePushdownIgnoreMultivalues, which is the same but with StartsWith. If one ails, the other probably fails too


description:text
;
Expand All @@ -1294,6 +1294,8 @@ beta | Kubernetes cluster
;

lucenePushdownMultipleIndices
required_capability: index_metadata_field
required_capability: casting_operator

from airports* metadata _index
| where starts_with(name::keyword, "Sahn") and ends_with(abbrev, "UH")
Expand All @@ -1310,6 +1312,7 @@ LUH | Sahnewal | airports_web
;

lucenePushdownOr
required_capability: casting_operator

from airports
| where starts_with(name::keyword, "Sahn") or ends_with(abbrev, "UH")
Expand All @@ -1323,6 +1326,7 @@ RUH | King Khalid Int'l
;

lucenePushdownMultipleOr
required_capability: casting_operator

from airports
| where starts_with(name::keyword, "Sahn") or ends_with(abbrev, "UH") or starts_with(abbrev, "OOL")
Expand All @@ -1337,6 +1341,8 @@ RUH | King Khalid Int'l
;

lucenePushdownMultipleAnd
required_capability: index_metadata_field
required_capability: casting_operator

from airports metadata _index
| where starts_with(name::keyword, "Sahn") and ends_with(abbrev, "UH")
Expand All @@ -1349,6 +1355,7 @@ LUH | Sahnewal | airports
;

lucenePushdownMixAndOr
required_capability: casting_operator

from airports
| where starts_with(name::keyword, "Sahn") and (starts_with(name::keyword, "Abc") or ends_with(abbrev, "UH"))
Expand All @@ -1360,6 +1367,8 @@ LUH | Sahnewal | 9
;

lucenePushdownMixOrAnd
required_capability: index_metadata_field
required_capability: casting_operator

from airports* metadata _index
| where starts_with(name::keyword, "Sahn") or (starts_with(abbrev, "G") and ends_with(name::keyword, "Falls Int'l"))
Expand Down