Bump recorder version to v1.5.0 #537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshshanmugam
previously approved these changes
Dec 16, 2024
| @@ -309,218 +309,6 @@ WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | |||
| FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR | |||
| OTHER DEALINGS IN THE SOFTWARE. | |||
|
|
|||
| --- | |||
| This product relies on playwright-core | |||
There was a problem hiding this comment.
Oops again? Something wrong with our tooling?
There was a problem hiding this comment.
Ths has consistently failed for a really long time, needs fixed.
There was a problem hiding this comment.
Playwright core does not include a license file in the package, thus when it gets installed there's no license for the script to pick up and include in NOTICE.txt.
There was a problem hiding this comment.
Hey - I added some automation to pull down the correct license file for the current tag in node_modules - see here: 6dd49b0
This should fix the playwright bit that always gets deleted or needs manual inclusion.
justinkambic
force-pushed
the
1.5.0
branch
2 times, most recently
from
9bd7f95 to
762f172
Compare
This reverts commit ae094e5.
…ed in arm package.
This reverts commit 9ec09de.
order matters Update .buildkite/release.yml Update .buildkite/release.yml help with the name of the step docs and debug
v1v
reviewed
Jan 14, 2025
| @@ -36,17 +37,24 @@ steps: | |||
|
|
|||
| - wait: ~ | |||
|
|
|||
| - label: Download signed artifacts | |||
| # The order matters here, we need to download the gpg files first, then the windows and macos files | |||
v1v
reviewed
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the recorder version to 1.5.0. The old README specifies the dev should simply push this to
main, but we no longer have permission to do that so a PR is the route it must take.