Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump recorder version to v1.5.0 #537

Open
wants to merge 128 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
128 commits
Select commit Hold shift + click to select a range
70645bc
Update NOTICE.txt.
justinkambic Dec 16, 2024
b0f4475
1.5.0
justinkambic Dec 16, 2024
de748d6
Try installing archiver-utils as a top-level dep to fix issue in prod…
justinkambic Dec 17, 2024
099b2b8
1.5.1
justinkambic Dec 17, 2024
a6d07c5
Downgrade electron/electron-builder.
justinkambic Dec 18, 2024
8fa1315
1.5.2
justinkambic Dec 18, 2024
57e8655
Revert "Downgrade electron/electron-builder."
justinkambic Dec 18, 2024
2c03348
1.5.3
justinkambic Dec 18, 2024
6c00951
1.5.4
justinkambic Dec 18, 2024
dffa6cc
Try installing sharp directly.
justinkambic Dec 18, 2024
1461c9d
Specify additional entitlements debugging gatekeeper denial on notari…
justinkambic Dec 18, 2024
5da33e2
1.5.5
justinkambic Dec 18, 2024
4dcf41f
Attempt to use electron-rebuild to ensure correct binaries are includ…
justinkambic Dec 18, 2024
270aa11
1.5.6
justinkambic Dec 18, 2024
9ec09de
Try specifying native files in asarUnpack for macOS.
justinkambic Dec 18, 2024
6c237f3
1.5.7
justinkambic Dec 18, 2024
461ddb8
Revert "Try specifying native files in asarUnpack for macOS."
justinkambic Dec 19, 2024
da4e571
Only build macos for arm64.
justinkambic Dec 19, 2024
5a1b00e
1.5.8
justinkambic Dec 19, 2024
e7a7b21
Try asar unpack instructions for macos build.
justinkambic Dec 19, 2024
83c6cfd
1.5.9
justinkambic Dec 19, 2024
2116697
Build for both arch and add debug logging to electron-builder.
justinkambic Dec 19, 2024
b52109d
1.5.10
justinkambic Dec 19, 2024
f9ed58c
Update before-pack to include a sharp install step targeted at os and…
justinkambic Dec 19, 2024
79377e7
1.5.11
justinkambic Dec 19, 2024
9265d02
Add additional logging to before-pack.
justinkambic Dec 19, 2024
cd3b5eb
1.5.12
justinkambic Dec 19, 2024
5d278a6
Remove manual rebuild.
justinkambic Dec 19, 2024
e554157
1.5.13
justinkambic Dec 19, 2024
d08f102
Remove electron-rebuild and sharp from deps.
justinkambic Dec 19, 2024
4fdc59c
1.5.14
justinkambic Dec 19, 2024
5b78e35
Add npm install directly to posintsall script.
justinkambic Dec 19, 2024
5884111
Working locally, test against CI env.
justinkambic Jan 6, 2025
1f98bb1
1.5.15
justinkambic Jan 6, 2025
430b45c
Log node_modules pre-build.
justinkambic Jan 6, 2025
6d29f4b
1.5.16
justinkambic Jan 6, 2025
e8ac0eb
Add script that checks for resource presence in postbuild step.
justinkambic Jan 6, 2025
d433966
1.5.17
justinkambic Jan 6, 2025
1431409
Add asar-unpack defs for windows and linux. Fix a typo.
justinkambic Jan 6, 2025
da5897e
1.5.18
justinkambic Jan 6, 2025
406be9e
Add onNodeModuleFile script. Theoretically, this sounds like a promis…
justinkambic Jan 7, 2025
55c1a2f
Export check-sharp script to its own file for reuse.
justinkambic Jan 7, 2025
bacf693
Call check-sharp on `afterExtract` hook as well.
justinkambic Jan 7, 2025
851b4b0
Enable electron-builder debug logging.
justinkambic Jan 7, 2025
6c55519
1.5.19
justinkambic Jan 7, 2025
800fd0b
Disable electron rebuild?
justinkambic Jan 7, 2025
3056f60
1.5.20
justinkambic Jan 7, 2025
1c90353
Try copying files in after-pack.
justinkambic Jan 7, 2025
2f145b7
1.5.21
justinkambic Jan 7, 2025
a89661c
Amend resource path copy in script and disable electron-builder debug…
justinkambic Jan 7, 2025
a26211f
1.5.22
justinkambic Jan 7, 2025
d597027
Fix bug in copy code.
justinkambic Jan 7, 2025
efaf4c5
1.5.23
justinkambic Jan 7, 2025
445896f
Re-enable debug logging.
justinkambic Jan 7, 2025
8e8ae36
1.5.24
justinkambic Jan 7, 2025
7dc34a9
Turn npm rebuild back on.
justinkambic Jan 7, 2025
5bbe9f9
1.5.25
justinkambic Jan 7, 2025
15ae13e
Just for fun, try building with asar disabled.
justinkambic Jan 8, 2025
838f999
1.5.26
justinkambic Jan 8, 2025
7b0c7c5
Try using `extraResources` to copy sharp bins.
justinkambic Jan 8, 2025
cf3727a
1.5.27
justinkambic Jan 8, 2025
de5ca8d
Trying more electron-builder commands, npmRebuild and including bins …
justinkambic Jan 8, 2025
89cd561
1.5.28
justinkambic Jan 8, 2025
3450640
Try pre-build script.
justinkambic Jan 8, 2025
a751a21
1.5.29
justinkambic Jan 8, 2025
0b91d6b
Trying to manually move files into place before build.
justinkambic Jan 8, 2025
0b3f9e5
Trying to manually move files into place before build.
justinkambic Jan 8, 2025
83a44c1
1.5.30
justinkambic Jan 8, 2025
849b827
Do not quit check sharp script if the resource path does not exist.
justinkambic Jan 8, 2025
0fc3de5
1.5.31
justinkambic Jan 8, 2025
997d570
Log contents of node_modules during the module copying phase.
justinkambic Jan 9, 2025
21e6aee
1.5.32
justinkambic Jan 9, 2025
3af6d38
Remove asar unpack from config and adjust npm env vars.
justinkambic Jan 9, 2025
651a569
1.5.33
justinkambic Jan 9, 2025
6c5c97b
Include package in `files` list.
justinkambic Jan 9, 2025
8243676
1.5.34
justinkambic Jan 9, 2025
d0ffbf8
Try extra resources direct path.
justinkambic Jan 9, 2025
75c4253
1.5.35
justinkambic Jan 9, 2025
3f83ad4
Re-enable debug logs.
justinkambic Jan 9, 2025
97b57d6
Add command to save a cleaner version of the logs.
justinkambic Jan 9, 2025
0d57c6c
1.5.36
justinkambic Jan 9, 2025
3353328
Try pre-release eb.
justinkambic Jan 10, 2025
ac86d77
1.5.37
justinkambic Jan 10, 2025
8bd18a7
Remove sharp as dependency.
justinkambic Jan 10, 2025
932664e
1.5.38
justinkambic Jan 10, 2025
c90eb92
Re-enable sharp script.
justinkambic Jan 10, 2025
0702e2b
1.5.39
justinkambic Jan 10, 2025
e3c2c04
Revert "Try pre-release eb."
justinkambic Jan 10, 2025
10bfdb0
Change asar based on something the docs said.
justinkambic Jan 10, 2025
6e01c6b
1.5.40
justinkambic Jan 10, 2025
9785137
Log env at npm install time.
justinkambic Jan 10, 2025
0a46d69
1.5.41
justinkambic Jan 10, 2025
9e92203
remove other platforms besides arm/mac
justinkambic Jan 10, 2025
ca63e21
1.5.42
justinkambic Jan 10, 2025
e513f38
Fix package json to only build for mac.
justinkambic Jan 10, 2025
bf008f2
1.5.43
justinkambic Jan 10, 2025
a505814
Revert new entitlements to ensure it\'s not messing up notarization.
justinkambic Jan 13, 2025
07774b4
1.5.44
justinkambic Jan 13, 2025
64efe69
Split build to separate configs.
justinkambic Jan 13, 2025
7b81fda
1.5.44
justinkambic Jan 13, 2025
9e60941
1.5.45
justinkambic Jan 13, 2025
24b40b6
Remove clean command from build script.
justinkambic Jan 13, 2025
7e5c96e
1.5.46
justinkambic Jan 13, 2025
f8a428f
release: run signing in sequential and download signed files in order
v1v Jan 13, 2025
a9606b1
1.5.47
v1v Jan 14, 2025
1d36aa6
Update .buildkite/scripts/package.sh
v1v Jan 14, 2025
e041612
Fix: playwright inspector window no longer opens when recording sessi…
justinkambic Jan 14, 2025
747f363
Merge branch '1.5.0' of github.com:justinkambic/synthetics-recorder i…
justinkambic Jan 14, 2025
6dd49b0
Automate inclusion of playwright license by pulling from repo.
justinkambic Jan 14, 2025
79aafe5
Begin cleaning up and iteratively testing output.
justinkambic Jan 14, 2025
f7fae5e
1.5.48
justinkambic Jan 14, 2025
5a7fc98
Clean up pack scripts.
justinkambic Jan 14, 2025
3806dd9
Re-introduce fix-sharp to beforeBuild hook.
justinkambic Jan 14, 2025
58cd4b5
Remove onNodeModuleFile script.
justinkambic Jan 14, 2025
1786437
1.5.49
justinkambic Jan 14, 2025
22e0f9c
Attempt to put packaging steps in separate commands.
justinkambic Jan 15, 2025
590016e
1.5.50
justinkambic Jan 15, 2025
51ac792
Fix syntax error.
justinkambic Jan 15, 2025
f46851b
1.5.51
justinkambic Jan 15, 2025
8f6d81d
Remove unused build hook.
justinkambic Jan 15, 2025
8648d56
Redo build titles.
justinkambic Jan 15, 2025
1ef4fcd
1.5.52
justinkambic Jan 15, 2025
1bd2cf5
Re-add `archiver-utils` as a dependency, it is apparently essential.
justinkambic Jan 15, 2025
701631b
1.5.53
justinkambic Jan 15, 2025
843b078
Re-add `clean` to standard build script.
justinkambic Jan 15, 2025
1ba1ff3
Revert "Re-add `clean` to standard build script."
justinkambic Jan 15, 2025
dd49a84
Test output with checkSharp removed.
justinkambic Jan 15, 2025
eb702f4
1.5.54
justinkambic Jan 15, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 39 additions & 4 deletions .buildkite/release.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,38 @@
---
# $yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json
steps:
- label: "Package :package:"
- label: "Package Mac ARM64 :package: :mac:"
command: ".buildkite/scripts/package.sh"
artifact_paths: "package.log"
agents:
provider: orka
imagePrefix: generic-13-ventura-x64
env:
PACKAGE_PLATFORM: "macos_arm64"
- label: "Package Mac x64 :package: :mac:"
command: ".buildkite/scripts/package.sh"
artifact_paths: "package.log"
agents:
provider: orka
imagePrefix: generic-13-ventura-x64
env:
PACKAGE_PLATFORM: "macos_x64"
- label: "Package Linux x64 :package: :linux:"
command: ".buildkite/scripts/package.sh"
artifact_paths: "package.log"
agents:
provider: orka
imagePrefix: generic-13-ventura-x64
env:
PACKAGE_PLATFORM: "linux"
- label: "Build Windows x64 :package: :windows:"
command: ".buildkite/scripts/package.sh"
artifact_paths: "package.log"
agents:
provider: orka
imagePrefix: generic-13-ventura-x64
env:
PACKAGE_PLATFORM: "windows"

- wait: ~

Expand Down Expand Up @@ -36,17 +63,24 @@ steps:

- wait: ~

- label: Download signed artifacts
# The order matters here, we need to download the gpg files first, then the windows and macos files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #541

# The current BK pipeline helpers use an opinionated folder names (artifacts-to-sign and signed-artifacts)
- label: Download signed artifacts (windows and gpg)
commands:
- .buildkite/scripts/download-signed-artifacts.sh "gpg-sign-service" "gpg"
- .buildkite/scripts/download-signed-artifacts.sh "macos-sign-service" "macos"
- .buildkite/scripts/download-signed-artifacts.sh "windows-sign-service" "windows"
- .buildkite/scripts/download-signed-artifacts.sh "gpg-sign-service" "gpg" | buildkite-agent pipeline upload
- .buildkite/scripts/download-signed-artifacts.sh "macos-sign-service" "macos" | buildkite-agent pipeline upload
- .buildkite/scripts/download-signed-artifacts.sh "windows-sign-service" "windows" | buildkite-agent pipeline upload

- wait: ~

- label: Download signed artifacts (macos)
commands:
- .buildkite/scripts/download-signed-artifacts.sh "macos-sign-service" "macos"
- .buildkite/scripts/download-signed-artifacts.sh "macos-sign-service" "macos" | buildkite-agent pipeline upload

- wait: ~

- label: "Publish S3 Artifacts :s3:"
trigger: unified-release-publish-s3-artifacts
key: publish-s3-service
Expand All @@ -60,6 +94,7 @@ steps:
- label: "Publish GitHub Release :github:"
commands:
- .buildkite/scripts/create-github-release.sh
# The steps name are set as part of the .buildkite/scripts/download-signed-artifacts.sh script
depends_on:
- "gpg"
- "macos"
Expand Down
15 changes: 14 additions & 1 deletion .buildkite/scripts/create-github-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,22 @@ set -eox pipefail

DIST_LOCATION=signed-artifacts
echo "--- Download signed artifacts"
#
# Download the signed artifacts from the previous step but using the below order
# gpg, windows and macos.
# This should help with the signing process and download the files in the correct
# order. gpg signing signs all the files, but the dmg files need to be signed
# separately as part of the Macos BK pipeline helper.
# As long as, the signing process is split in different types and use the same
# folder name, we need this hack.
#
buildkite-agent artifact download --step gpg "$DIST_LOCATION/*.*" ./
buildkite-agent artifact download --step macos "$DIST_LOCATION/*.*" ./
# help with debugging
ls -ltra "$DIST_LOCATION/"
buildkite-agent artifact download --step windows "$DIST_LOCATION/*.*" ./
ls -ltra "$DIST_LOCATION/"
buildkite-agent artifact download --step macos "$DIST_LOCATION/*.*" ./
ls -ltra "$DIST_LOCATION/"

echo "--- List signed artifacts"
ls -l "$DIST_LOCATION/"
Expand Down
3 changes: 2 additions & 1 deletion .buildkite/scripts/download-signed-artifacts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,12 @@ if [ -z "$SIGN_BUILD_ID" ] ; then
fi

cat << EOF
- label: ":pipeline: Download signed artifacts"
- label: ":pipeline: Download signed artifacts $DOWNLOAD_STEP_NAME"
key: "$DOWNLOAD_STEP_NAME"
commands:
- mkdir -p signed-artifacts
- buildkite-agent artifact download --build "$SIGN_BUILD_ID" "*.*" signed-artifacts/
- ls -ltra signed-artifacts/
- buildkite-agent artifact upload "signed-artifacts/*.*"
agents:
image: docker.elastic.co/ci-agent-images/ubuntu-build-essential
Expand Down
29 changes: 28 additions & 1 deletion .buildkite/scripts/package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,39 @@ echo "--- run release-ci"
export CSC_IDENTITY_AUTO_DISCOVERY=false
# Disable notarize, see scripts/notarize.js
export SKIP_NOTARIZATION=true
npm run release-ci

if [ -z "$PACKAGE_PLATFORM" ]; then
echo "Error: PACKAGE_PLATFORM must be set to continue."
exit 1
fi

case "$PACKAGE_PLATFORM" in
"linux")
echo "--- Package for Linux"
npm run release-ci_linux-x64 | tee package.log
;;

"macos_arm64")
echo "--- Package for MacOS ARM64"
npm run release-ci_mac-arm64 | tee package.log
;;

"macos_x64")
echo "--- Package for MacOS x64"
npm run release-ci_mac-x64 | tee package.log
;;

"windows")
echo "--- Package for Windows"
npm run release-ci_windows-x64 | tee package.log
;;
esac

# Store unsigned artifacts
if [ -n "$BUILDKITE" ] ; then
echo "--- Upload artifacts"
mv dist artifacts-to-sign
# We cannot upload artifacts-to-sign/*.* since it contains some generated files builder-debug, .blockmap and so on
# (only *nix)
buildkite-agent artifact upload "artifacts-to-sign/*.deb;artifacts-to-sign/*.dmg;artifacts-to-sign/*.zip"

Expand Down
Loading
Loading