Switch to Xcode 15 (with the iOS 16.4 Simulator for tests still) #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against f78d22e |
pixlwave
force-pushed
the
doug/xcode-15
branch
from
c548176 to
8b6e47c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2113 +/- ##
===========================================
- Coverage 71.92% 71.91% -0.01%
===========================================
Files 511 511
Lines 34722 34722
Branches 16673 16673
===========================================
- Hits 24973 24972 -1
Misses 9137 9137
- Partials 612 613 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Use iOS 16.4 simulators from Xcode 14 as iOS 17.0.1 simulators are **super** slow.
Snapshot fix.
pixlwave
force-pushed
the
doug/xcode-15
branch
from
8b6e47c to
9028443
Compare
pixlwave
changed the title
pixlwave
commented
Nov 21, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Nov 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #2007, this switches the project to use Xcode 15, but with the iOS 16.4 simulator linked from Xcode 14 on CI to work around the performance issues.
Updated Preview snapshots are mainly about the default change of continuous corners on rounded rectangles and capsules. There are some rendering errors but those don't appear in real life.
UI tests and integration tests both work locally too and the precision is lower on UI tests so it doesn't pick up the corner shape change.