Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the notification string for incoming calls #3723

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 31, 2025

fixes #3724

@Velin92 Velin92 requested a review from a team as a code owner January 31, 2025 16:03
@Velin92 Velin92 requested review from pixlwave and removed request for a team January 31, 2025 16:03
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Element CI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Velin92 Velin92 added the pr-change for updates to an existing feature label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.78%. Comparing base (9706985) to head (306036f).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
NSE/Sources/NotificationContentBuilder.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3723      +/-   ##
===========================================
+ Coverage    78.74%   78.78%   +0.03%     
===========================================
  Files          792      792              
  Lines        68214    68214              
===========================================
+ Hits         53716    53740      +24     
+ Misses       14498    14474      -24     
Flag Coverage Δ
unittests 70.40% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Velin92 Velin92 merged commit 342f252 into develop Jan 31, 2025
14 of 15 checks passed
@Velin92 Velin92 deleted the mauroromito/incoming_call_notification_update branch January 31, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update the incoming call notification string
3 participants