Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the notification string for incoming calls #3723

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Updated the notification string for incoming calls #3723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ElementX/Resources/Localizations/en-US.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@
"notification_channel_noisy" = "Noisy notifications";
"notification_channel_ringing_calls" = "Ringing calls";
"notification_channel_silent" = "Silent notifications";
"notification_incoming_call" = "Incoming call";
"notification_incoming_call" = "📹 Incoming call";
"notification_inline_reply_failed" = "** Failed to send - please open room";
"notification_invite_body" = "Invited you to chat";
"notification_invite_body_with_sender" = "%1$@ invited you to chat";
Expand Down
2 changes: 1 addition & 1 deletion ElementX/Resources/Localizations/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@
"notification_channel_noisy" = "Noisy notifications";
"notification_channel_ringing_calls" = "Ringing calls";
"notification_channel_silent" = "Silent notifications";
"notification_incoming_call" = "Incoming call";
"notification_incoming_call" = "📹 Incoming call";
"notification_inline_reply_failed" = "** Failed to send - please open room";
"notification_invite_body" = "Invited you to chat";
"notification_invite_body_with_sender" = "%1$@ invited you to chat";
Expand Down
2 changes: 1 addition & 1 deletion ElementX/Sources/Generated/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ internal enum L10n {
}
/// Notification
internal static var notificationFallbackContent: String { return L10n.tr("Localizable", "notification_fallback_content") }
/// Incoming call
/// 📹 Incoming call
internal static var notificationIncomingCall: String { return L10n.tr("Localizable", "notification_incoming_call") }
/// ** Failed to send - please open room
internal static var notificationInlineReplyFailed: String { return L10n.tr("Localizable", "notification_inline_reply_failed") }
Expand Down
2 changes: 1 addition & 1 deletion NSE/Sources/NotificationContentBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ struct NotificationContentBuilder {

private func processCallNotifyEvent(notificationItem: NotificationItemProxyProtocol, mediaProvider: MediaProviderProtocol?) async throws -> UNMutableNotificationContent {
let notification = try await processCommonRoomMessage(notificationItem: notificationItem, mediaProvider: mediaProvider)
notification.body = L10n.commonCallStarted
notification.body = L10n.notificationIncomingCall
return notification
}

Expand Down
Loading