-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4076: Add disable_badge_count to pusher configuration #17975
Merged
Merged
+98
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MSC just got the very last change we needed. This PR can be reviewed. |
anoadragon453
requested changes
Dec 2, 2024
Co-authored-by: Andrew Morgan <[email protected]>
anoadragon453
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience on this one. This now LGTM!
Thanks @anoadragon453 for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements MSC4076: Let E2EE clients calculate app badge counts themselves (disable_badge_count).
The MSC is not merged yet but I have not put this new code under a experimental feature flag. The behavior change is very limited to the homerserver / client / push gateway interfaces. It can only happen if the client asks for it.Note: this PR now requires setting the experimental feature flag
msc4076_enabled
- @anoadragon453Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)