Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4076: Add disable_badge_count to pusher configuration #17975

Merged
merged 11 commits into from
Dec 3, 2024

Conversation

manuroe
Copy link
Member

@manuroe manuroe commented Nov 29, 2024

This PR implements MSC4076: Let E2EE clients calculate app badge counts themselves (disable_badge_count).

The MSC is not merged yet but I have not put this new code under a experimental feature flag. The behavior change is very limited to the homerserver / client / push gateway interfaces. It can only happen if the client asks for it.

Note: this PR now requires setting the experimental feature flag msc4076_enabled - @anoadragon453

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@manuroe
Copy link
Member Author

manuroe commented Dec 2, 2024

The MSC just got the very last change we needed. This PR can be reviewed.

@manuroe manuroe marked this pull request as ready for review December 2, 2024 08:41
@manuroe manuroe requested a review from a team as a code owner December 2, 2024 08:41
changelog.d/17975.feature Outdated Show resolved Hide resolved
synapse/push/httppusher.py Outdated Show resolved Hide resolved
tests/push/test_http.py Outdated Show resolved Hide resolved
Co-authored-by: Andrew Morgan <[email protected]>
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience on this one. This now LGTM!

@anoadragon453 anoadragon453 merged commit abf44ad into element-hq:develop Dec 3, 2024
39 checks passed
@manuroe
Copy link
Member Author

manuroe commented Dec 4, 2024

Thanks @anoadragon453 for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants