Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4076: Let E2EE clients calculate app badge counts themselves (disable_badge_count) #4076

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented Nov 12, 2023

This gives a way for E2EE-aware clients to accurately maintain their own app badge counts, rather than having the server incorrectly override them based on partial information.

Solves element-hq/element-x-ios#3151

Rendered

Implementations:

@turt2live turt2live added push proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Nov 12, 2023
@manuroe manuroe changed the title MSC4076: Let E2EE clients calculate app & E2EE-room badge counts themselves MSC4076: Let E2EE clients calculate app badge counts themselves (disable_badge_count) Nov 29, 2024
@manuroe
Copy link
Contributor

manuroe commented Nov 29, 2024

Synapse PR: element-hq/synapse#17975

It removes the parent counts field as proposed in #4076 (comment). I will undraft the PR once we agree on the spec.

@ara4n ara4n removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Nov 29, 2024
@ara4n
Copy link
Member Author

ara4n commented Dec 1, 2024

I will undraft the PR once we agree on the spec.

I am not seeing any disagreements on the spec? There is no reason for the PR to be draft if you think it's good for review. The only thing stopping FCP on this MSC right now is the lack of implementation, so please don't block the implementations on the MSC getting FCP'd ;)

@manuroe
Copy link
Contributor

manuroe commented Dec 2, 2024

I will undraft the PR once we agree on the spec.

I am not seeing any disagreements on the spec? There is no reason for the PR to be draft if you think it's good for review. The only thing stopping FCP on this MSC right now is the lack of implementation, so please don't block the implementations on the MSC getting FCP'd ;)

I wanted to have a Synapse PR that matches the MSC. With your last commit on this MSC, the Synapse PR can be reviewed. Thanks!

rooms with invisible events) - and at worst will race and fight[^2] with the app badge count maintained locally by the
app, if any.

Therefore we need a way for sophisticated E2EE clients to tell the server to stop overriding their app badge count.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document doesn't answer what feels like a fair question to have: Why do the sophisticated E2EE clients not just ignore the count?

My presumption is that this is done at the OS-level and the app does not get the choice?

So the next point might be: is this MSC really superior to performing this filtering in the application-specific push gateway (Sygnal) like many other such platform-specific quirks, which already have configuration options?

anoadragon453 pushed a commit to element-hq/synapse that referenced this pull request Dec 3, 2024
This PR implements [MSC4076: Let E2EE clients calculate app badge counts
themselves
(disable_badge_count)](matrix-org/matrix-spec-proposals#4076).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal push
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants