Support for OpenFile to Intellij #35

zaideygrek · 2022-04-28T02:37:01Z

No description provided.

This reverts commit 21c7791.

changeset-bot · 2022-04-28T02:37:03Z

🦋 Changeset detected

Latest commit: 75ed249

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
click-to-react-component	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ericclemmons · 2022-04-28T22:23:02Z

packages/click-to-react-component/src/ClickToComponent.js

      setState(State.IDLE)
    },
    [editor]
  )

+  const openFileInIDE = (file) => {
+    if (editor === 'intellij') {
+      const url = `http://localhost:63342/api/file/${file}`


TIL! I'd like to move this logic up so that lineNumber & columnNumber can be used.

https://github.com/JetBrains/intellij-community/blob/a77365debaadcf00b888a977d89512f3f0f3cf9e/platform/built-in-server/src/org/jetbrains/ide/OpenFileHttpService.kt#L52-L59

This seems related to #28, #29, or #26, too 🤔

I confirm that in the state it works well, intellij opens the file in the right row and in the right column.
Would you prefer to use another syntax?

@ericclemmons JetBrain's IDEs support both formats: file.kt:100:34 and file.kt&line=100&column=34. No reason for additional logic here. It is just work.

dartess · 2022-04-29T21:35:14Z

add intellij to export type Editor = 'vscode' | 'vscode-insiders' please

dartess · 2022-04-29T21:50:42Z

jetbrains IDEs partially support URL handling, like this:

webstorm://open?file=/Path/To/File.tsx&line=4&column=5

The following schemes are supported:

'webstorm',
'phpstorm', // also occupies 'idea'
'pycharm',
'x-mine', // rubymine
'goland',
'idea', // may conflict with phpstorm

Unfortunately this only works for macos.

But I still think it might be faster than opening via http://localhost:63342

Perhaps it is worth doing a check on the operating system and doing two ways? What do you think?

zaideygrek · 2022-05-04T11:34:36Z

jetbrains IDEs partially support URL handling, like this:
webstorm://open?file=/Path/To/File.tsx&line=4&column=5
The following schemes are supported:
'webstorm',
'phpstorm', // also occupies 'idea'
'pycharm',
'x-mine', // rubymine
'goland',
'idea', // may conflict with phpstorm
Unfortunately this only works for macos.

I tried this methos but jetbrains got an error: "Unsupported protocol" regression for URI handler.
There are unresolved issues like https://youtrack.jetbrains.com/issue/IDEA-284396

The safest method remains http://localhost:63342, it is fast and simple. What do you think ?

dunklesToast · 2022-05-04T12:31:01Z

The safest method remains http://localhost:63342, it is fast and simple. What do you think ?

Just noticed that URL Handling works all the time, even when the IDE is closed, it'll then open it. The localhost server is only active when the IDE is open (which should be the case most of the time)

dartess · 2022-05-04T12:38:12Z

The localhost server is only active when the IDE is open (which should be the case most of the time)

I think it makes sense to add this to the documentation.

=======

We can implement both methods and describe their differences in the documentation. A consumer will choose a desired option. There is not even a coincidence of the names of the editors.

It seems to me that this PR does its job well.

I'd like to add schema support for specific IDEs later (if no one gets ahead of me).

zaideygrek · 2022-05-05T02:42:59Z

I added the possibility to change the default editor in the context menu. It stores the value in localstorage, so the project team can have different IDE preferences. What do you think ?

ryota-murakami · 2022-05-09T06:34:13Z

Thank you for everyone!
I'm pretty glad to this PR tractions as a WebStorm user!

dunklesToast · 2022-05-09T09:08:07Z

I added the possibility to change the default editor in the context menu. It stores the value in localstorage, so the project team can have different IDE preferences. What do you think ?

Not a bad idea. Could we somehow also create a more persistent solution to this? While developing I often clear the whole application data to reset something or test a fresh state. This would always reset this, right?
I only have two idea which are both not the best but maybe someone else has better ones.

Environment Variable
This could be tricky, because IIRC CRA only allows env vars prefixed with REACT_APP_ , but this would probably not work with Next.js or so out of the box (as Next.js needs to have env's specifically passed and then they are under publicRuntimeConfig and not process.env).
Read from window object
This ones probably a bit dirty / hacky but we could define a property (like window.CLICK_TO_COMPONENT_EDITOR) which users could set via UserScripts or some Custom JS Injector.

The order could be smth like "localStorage > window > environment" so localStorage would override window and env and window would take presence before environment if localStorage has nothing stored. Does that make sense to you?

dartess · 2022-05-09T12:12:47Z

I added the possibility to change the default editor in the context menu. It stores the value in localstorage, so the project team can have different IDE preferences. What do you think ?

Great idea. But sounds like a separate PR. I'm afraid adding new features (which are yet to be discussed) will slow down the approve of this PR.

dartess · 2022-05-09T12:13:18Z

@dunklesToast another dirty thought is to somehow use GET parameters. For example, take initial value from there and put it in LS or window.

This reverts commit 2522aff.

This reverts commit d9837db.

zaideygrek · 2022-05-11T00:10:06Z

Great idea. But sounds like a separate PR. I'm afraid adding new features (which are yet to be discussed) will slow down the approve of this PR.

You're right ! I revert code to change the default editor in the context menu. I will make a separate PR.

zaideygrek · 2022-05-17T22:46:11Z

@ericclemmons I'm waiting for your instructions if you have any, thanks

dartess · 2022-05-30T16:21:22Z

@ericclemmons hi! any updates here?

JohnyTheCarrot · 2022-08-13T09:49:21Z

Any update on this? Would love to have it, might just have to check out this PR if it isn't going to be merged.

mmelikyan · 2022-10-06T20:52:33Z

@zaideygrek Looks like this project is abandoned. We're gonna have to use a fork to have this feature implemented. :/

@ericclemmons per chance, could you please clarify if you still plan on supporting this repo? thank you!

ericclemmons · 2022-10-06T20:55:53Z

I struggled to get this working as a Chrome extension. That would be the best way for it to work without code changes and support per-machine IDEs. Paid dev is taking precedence, so if anyone wants to DM me about project rates, reach out via Twitter 🙏🏻

On Thu, Oct 6, 2022 at 3:52 PM Mika Melikyan ***@***.***> wrote: @zaideygrek <https://github.com/zaideygrek> Looks like this project is abandoned. We're gonna have to use a fork to have this feature implemented. :/ @ericclemmons <https://github.com/ericclemmons> per chance, could you please clarify if you still plan on supporting this repo? thank you! — Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADWTV4YNBN3HKCEEYB3GTWB43ZZANCNFSM5UQ5GIPA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Sent from Gmail Mobile

zaideygrek · 2022-10-06T21:19:44Z

What do you think about this chrome extension locatorJs ?

mmelikyan · 2022-10-07T00:18:44Z

I still think this is a fantastic solution and could actually be turned into a big product with more features, but as-is it's awesome doing its job!

I've tried LocatorJs and it's not nearly as intuitive as click-to-component.

Concerning the IntelliJ support that this PR addresses, I've tested with WebStorm and works like a charm ✨

Please consider merging this :))

ericclemmons · 2023-03-30T17:52:52Z

I added
@dartess, @mmelikyan , & @zaideygrek collaborators.

Previously, this project was supported by Stripe but is not any longer.

dartess · 2023-04-03T17:41:10Z

about the comment above: sounds good, I think I can spend a little time on it. but I don't have much experience with versioning support and stuff around releases.

@ericclemmons do you still own and release new versions? If so, can you add an available CONTRIBUTING.md to the project?

dartess · 2023-04-03T17:42:07Z

about this PR: @zaideygrek will you have time to update this PR or will I pick up this task?

zaideygrek · 2023-04-04T03:52:50Z

Sorry I don't have time to clean the code and continue this PR.

packages/click-to-react-component/src/ClickToComponent.js

alanhe421 · 2025-01-08T06:32:17Z

I made a PR

#98

But alas, there has been no merger.

zaideygrek added 11 commits April 28, 2022 11:42

feat(IDE): add open IDE to intellij

0133f8a

feat(IDE): add open IDE to intellij

ede2875

fix(readme): new cmd

c075aad

fix(readme): new cmd

58f7a48

fix(readme): new cmd

6cb4a6c

fix(readme): new cmd

1e851f3

fix(readme): new cmd

e37bce7

Revert "Compare to React DevTools"

b96e397

This reverts commit 21c7791.

fix(readme): new cmd

17548e4

fix(readme): new cmd

da6758c

fix(readme): new cmd

2f41873

zaideygrek and others added 2 commits April 28, 2022 13:40

Create soft-taxis-search.md

bf03710

fix(readme): new cmd

502fa5e

ericclemmons reviewed Apr 28, 2022

View reviewed changes

fix(type): add intellij to export type Editor

2522aff

fix(IDE): add link to change default editor

d9837db

zaideygrek requested a review from ericclemmons May 8, 2022 22:42

zaideygrek and others added 2 commits May 11, 2022 10:52

Revert "fix(type): add intellij to export type Editor"

d08f8f7

This reverts commit 2522aff.

Merge branch 'ericclemmons:main' into main

81e0ea7

zaideygrek added 2 commits May 11, 2022 11:04

Revert "fix(IDE): add link to change default editor"

92416ba

This reverts commit d9837db.

fix(type): add intellij to export type Editor

75ed249

ericclemmons requested changes Apr 5, 2023

View reviewed changes

packages/click-to-react-component/src/ClickToComponent.js Outdated Show resolved Hide resolved

zaideygrek force-pushed the main branch from e68b62e to 75ed249 Compare April 5, 2023 03:02

zjffun mentioned this pull request Aug 5, 2023

Support for onOpenComponent callback #29

Closed

zaideygrek closed this Jan 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for OpenFile to Intellij #35

Support for OpenFile to Intellij #35

zaideygrek commented Apr 28, 2022

changeset-bot bot commented Apr 28, 2022 •

edited

Loading

ericclemmons Apr 28, 2022

zaideygrek Apr 28, 2022

dartess May 4, 2022 •

edited

Loading

dartess commented Apr 29, 2022 •

edited

Loading

dartess commented Apr 29, 2022

zaideygrek commented May 4, 2022

dunklesToast commented May 4, 2022

dartess commented May 4, 2022

zaideygrek commented May 5, 2022

ryota-murakami commented May 9, 2022

dunklesToast commented May 9, 2022

dartess commented May 9, 2022

dartess commented May 9, 2022

zaideygrek commented May 11, 2022

zaideygrek commented May 17, 2022

dartess commented May 30, 2022

JohnyTheCarrot commented Aug 13, 2022

mmelikyan commented Oct 6, 2022

ericclemmons commented Oct 6, 2022 via email

zaideygrek commented Oct 6, 2022

mmelikyan commented Oct 7, 2022

ericclemmons commented Mar 30, 2023

dartess commented Apr 3, 2023

dartess commented Apr 3, 2023

zaideygrek commented Apr 4, 2023 •

edited

Loading

alanhe421 commented Jan 8, 2025 •

edited

Loading

Support for OpenFile to Intellij #35

Support for OpenFile to Intellij #35

Conversation

zaideygrek commented Apr 28, 2022

changeset-bot bot commented Apr 28, 2022 • edited Loading

🦋 Changeset detected

ericclemmons Apr 28, 2022

Choose a reason for hiding this comment

zaideygrek Apr 28, 2022

Choose a reason for hiding this comment

dartess May 4, 2022 • edited Loading

Choose a reason for hiding this comment

dartess commented Apr 29, 2022 • edited Loading

dartess commented Apr 29, 2022

zaideygrek commented May 4, 2022

dunklesToast commented May 4, 2022

dartess commented May 4, 2022

zaideygrek commented May 5, 2022

ryota-murakami commented May 9, 2022

dunklesToast commented May 9, 2022

dartess commented May 9, 2022

dartess commented May 9, 2022

zaideygrek commented May 11, 2022

zaideygrek commented May 17, 2022

dartess commented May 30, 2022

JohnyTheCarrot commented Aug 13, 2022

mmelikyan commented Oct 6, 2022

ericclemmons commented Oct 6, 2022 via email

zaideygrek commented Oct 6, 2022

mmelikyan commented Oct 7, 2022

ericclemmons commented Mar 30, 2023

dartess commented Apr 3, 2023

dartess commented Apr 3, 2023

zaideygrek commented Apr 4, 2023 • edited Loading

alanhe421 commented Jan 8, 2025 • edited Loading

I made a PR

changeset-bot bot commented Apr 28, 2022 •

edited

Loading

dartess May 4, 2022 •

edited

Loading

dartess commented Apr 29, 2022 •

edited

Loading

zaideygrek commented Apr 4, 2023 •

edited

Loading

alanhe421 commented Jan 8, 2025 •

edited

Loading