-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OpenFile to Intellij #35
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0133f8a
feat(IDE): add open IDE to intellij
zaideygrek ede2875
feat(IDE): add open IDE to intellij
zaideygrek c075aad
fix(readme): new cmd
zaideygrek 58f7a48
fix(readme): new cmd
zaideygrek 6cb4a6c
fix(readme): new cmd
zaideygrek 1e851f3
fix(readme): new cmd
zaideygrek e37bce7
fix(readme): new cmd
zaideygrek b96e397
Revert "Compare to React DevTools"
zaideygrek 17548e4
fix(readme): new cmd
zaideygrek da6758c
fix(readme): new cmd
zaideygrek 2f41873
fix(readme): new cmd
zaideygrek bf03710
Create soft-taxis-search.md
zaideygrek 502fa5e
fix(readme): new cmd
zaideygrek 2522aff
fix(type): add intellij to export type Editor
zaideygrek d9837db
fix(IDE): add link to change default editor
zaideygrek d08f8f7
Revert "fix(type): add intellij to export type Editor"
zaideygrek 81e0ea7
Merge branch 'ericclemmons:main' into main
zaideygrek 92416ba
Revert "fix(IDE): add link to change default editor"
zaideygrek 75ed249
fix(type): add intellij to export type Editor
zaideygrek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"click-to-react-component": patch | ||
--- | ||
|
||
Added Support for OpenFile to Intellij |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,3 +105,4 @@ dist | |
|
||
# TernJS port file | ||
.tern-port | ||
/.idea/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL! I'd like to move this logic up so that
lineNumber
&columnNumber
can be used.https://github.com/JetBrains/intellij-community/blob/a77365debaadcf00b888a977d89512f3f0f3cf9e/platform/built-in-server/src/org/jetbrains/ide/OpenFileHttpService.kt#L52-L59
This seems related to #28, #29, or #26, too 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that in the state it works well, intellij opens the file in the right row and in the right column.
Would you prefer to use another syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericclemmons JetBrain's IDEs support both formats:
file.kt:100:34
andfile.kt&line=100&column=34
. No reason for additional logic here. It is just work.