Skip to content

feat: Re-enable recoloring for text window logs #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Conversation

finger563
Copy link
Contributor

No description provided.

Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 requested a review from Copilot June 12, 2025 20:17
@finger563 finger563 self-assigned this Jun 12, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to re-enable text recoloring in the text window logs and adjust the task stack size for the GUI component.

  • Reintroduces the call to enable text recoloring in the text window.
  • Increases the task's stack size from 6 KB to 10 KB for the GUI task.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
components/gui/src/text_window.cpp Re-enables text recoloring by uncommenting the API call.
components/gui/include/gui.hpp Increases the task stack size in the GUI configuration.
Comments suppressed due to low confidence (2)

components/gui/src/text_window.cpp:5

  • The obsolete comment about text recoloring is removed. Consider removing any redundant comments referencing deprecated behavior to avoid confusion in the future.
// lv_label_set_recolor(log_container_, true);

components/gui/include/gui.hpp:44

  • The task's stack size has been increased; please ensure that this change is well justified and consider adding a comment explaining the reason for the increased size.
.task_config = {.name = "Gui Task", .stack_size_bytes = 10 * 1024}

@finger563 finger563 added enhancement New feature or request lvgl text window labels Jun 12, 2025
@finger563 finger563 merged commit ed3c302 into main Jun 12, 2025
2 checks passed
@finger563 finger563 deleted the chore/recolor branch June 12, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant