Skip to content

feat: Re-enable recoloring for text window logs #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/gui/include/gui.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class Gui {
using namespace std::placeholders;
task_ = espp::Task::make_unique(
espp::Task::Config{.callback = [this](auto &m, auto &cv) -> bool { return update(m, cv); },
.task_config = {.name = "Gui Task", .stack_size_bytes = 6 * 1024}});
.task_config = {.name = "Gui Task", .stack_size_bytes = 10 * 1024}});
task_->start();
}

Expand Down
5 changes: 1 addition & 4 deletions components/gui/src/text_window.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@
void TextWindow::init(lv_obj_t *parent, size_t width, size_t height) {
Window::init(parent, width, height);
log_container_ = lv_label_create(parent_);
// NOTE: in LVGL v9 (up to 9.2.2) text recoloring was removed. In the future
// (>=9.2.3) it will be added back.
//
// lv_label_set_recolor(log_container_, true);
lv_label_set_recolor(log_container_, true);

// wrap text on long lines
lv_label_set_long_mode(log_container_, LV_LABEL_LONG_WRAP);
Expand Down