Verification flow verification classes #1879

marcocastignoli · 2025-01-30T13:04:53Z

This PR implements the new Verification class defined in #1823.

TODO:

~~Implement calling matchWithRuntimeBytecode and matchWithCreationTx in parallel~~
Fix should verify a contract with viaIR:true, optimizer disabled, and compiler <0.8.21
Implement Vyper constructor argument transformation test
Implement custom SourcifyLibError, with custom code/message
Include all transformations functions inside the Verification class
Move transformations into Verification/Transformations.ts
Do not include any dependency from the old ./src/lib folder

…tion

…lation

…ethods

Refactor project structure and import paths in lib-sourcify

…d compiler <0.8.21" test

manuelwedler

I only had a glimpse on the tests. Not sure if I can take a closer look before my vacation.

packages/lib-sourcify/src/Verification/VerificationTypes.ts

packages/lib-sourcify/src/SourcifyLibError.ts

packages/lib-sourcify/src/Verification/Verification.ts

- Extracted transformation functions from the Verification class to a separate module - Added a new SolidityBugType enum to handle specific compilation scenarios - Improved error handling for RPC unavailability

… interface

…lass

…ad of 'checkAndCreate'

…ndling

marcocastignoli · 2025-02-11T17:05:18Z

Should we wait merging because you also want to check the tests? @kuzdogan

marcocastignoli · 2025-02-13T15:24:29Z

TODO

Log the fetched bytecode length and first 32 bytes #1898

kuzdogan

Some small and some major things. I haven't looked at the tests yet to not make this review too large. I'll review the tests as the final next step.

My comments about the transformations array merging might be confusing. We can do a short call about that.

I'm reviewing this a bit thoroughly as this is an important piece of code but otherwise great work!

packages/lib-sourcify/src/Compilation/CompilationTypes.ts

packages/lib-sourcify/src/Compilation/VyperCompilation.ts

packages/lib-sourcify/src/Verification/Verification.ts

packages/lib-sourcify/src/Verification/Transformations.ts

packages/lib-sourcify/src/Verification/Verification.ts

packages/lib-sourcify/src/Verification/Transformations.ts

packages/lib-sourcify/src/Verification/Verification.ts

…re proceeding with bytecode matching

packages/lib-sourcify/src/Verification/VerificationTypes.ts

…uxdata`

…eatorTx input" test

kuzdogan

Couple issues. I didn't really check how comprehensive these tests are and if more are needed. Also there are a lot of potential for refactoring. For the sake of moving forward I'm leaving these out for this PR.

packages/lib-sourcify/test/Verification/Verification.spec.ts

packages/lib-sourcify/src/Verification/Verification.ts

packages/lib-sourcify/test/Verification/Verification.spec.ts

- Update source file reading to support nested directory structures - Clarify error message for bytecode matching with no auxdata - Improve test description for bytecode matching scenario

kuzdogan

LGTM!

LFG!

marcocastignoli added 12 commits January 30, 2025 11:20

implement Verifcation.ts

0443681

Refactor Verification.ts

5455f98

Add tests

bacfe4a

Add more tests

da81e76

Add comment to tests

268ceae

Add Vyper tests in Verification

8e0a65a

refactor Verification class

d620bee

handle ContructorTransformation

06e32f7

add comment

77d3f06

Refactor runtime bytecode matching and add call protection transforma…

0f44239

…tion

Refactor Verification class to use getter methods and improve encapsu…

1a2bbc7

…lation

Refactor AbstractCompilation to use protected properties and getter m…

95ffdf4

…ethods

kuzdogan mentioned this pull request Feb 4, 2025

Log the fetched bytecode length and first 32 bytes #1898

Merged

marcocastignoli and others added 14 commits February 4, 2025 10:28

Move check transformation functions into Verification class

f32de54

Refactor project structure and import paths in lib-sourcify

restore old verification.ts tests

aa62bdc

fix constructor arguments trasformantion tests

1f267f6

restore old types.ts

ef83999

add VerificationError class

4bd7b6b

Implement Vyper constructor argument transformation test

38c726b

Pass forceEmscripten option to compilation call

4bb267e

Split library map into runtime and creation maps

5cbd7d5

replace expectMatch with expectVerification

b1a8195

fix "should verify a contract with viaIR:true, optimizer disabled, an…

181bc29

…d compiler <0.8.21" test

Add test for library verification with call protection transformation

fecc3ba

fix call protection test

c31aaa8

increase coverage

591cb3a

add missing tests from verification.spec.ts increasing coverage

ff15507

marcocastignoli marked this pull request as ready for review February 5, 2025 07:00

manuelwedler requested changes Feb 6, 2025

View reviewed changes

Refactor bytecode transformations and verification logic

abde5fa

- Extracted transformation functions from the Verification class to a separate module - Added a new SolidityBugType enum to handle specific compilation scenarios - Improved error handling for RPC unavailability

marcocastignoli added 10 commits February 10, 2025 16:27

Update error handling for bytecode fetching in Sourcify verification

1cb2aa4

Remove unnecessary compilationTarget deletion in SolidityCompilation

8df9015

Refactor bytecode matching method signature and remove unused context…

488d562

… interface

Improve bytecode matching readability with descriptive variable names

a55ca31

Remove unused getter abiEncodedConstructorArguments in Verification c…

6126e53

…lass

Refactor Solidity settings type and improve bug handling in verification

ebfe9ab

Update SolidityBugType and improve error handling in verification tests

ed4fb93

Renamed functions in Transformations.ts to use 'extract' prefix inste…

bf73ff6

…ad of 'checkAndCreate'

Simplify extra file input bug detection and remove redundant error ha…

232f0be

…ndling

Refactor Solidity metadata and compiler settings types

e29ad59

kuzdogan self-assigned this Feb 13, 2025

kuzdogan requested changes Feb 18, 2025

View reviewed changes

marcocastignoli added 3 commits February 19, 2025 10:38

fixes for PR comments

f0e0fe7

Validate the bytecode length for Solidity and Vyper compilations befo…

3de45a2

…re proceeding with bytecode matching

do not use existing transformations/values in matchBytecode.

4d4cb96

manuelwedler reviewed Feb 21, 2025

View reviewed changes

packages/lib-sourcify/src/Verification/VerificationTypes.ts Outdated Show resolved Hide resolved

marcocastignoli added 3 commits February 24, 2025 09:18

Fix extra-file-input-bug at bytecode mismatch error

de425e2

fix `should return null match when there is no perfect match and no a…

db358c2

…uxdata`

fix "maliciously verify with creation bytecode that startsWith the cr…

0350c49

…eatorTx input" test

kuzdogan mentioned this pull request Feb 24, 2025

Check why the bytecode lengths are changing in the "extra_file_input" bug tests #1947

Open

kuzdogan requested changes Feb 24, 2025

View reviewed changes

fixes after PR review

30e5ee2

kuzdogan reviewed Feb 25, 2025

View reviewed changes

packages/lib-sourcify/src/Verification/Verification.ts Outdated Show resolved Hide resolved

kuzdogan reviewed Feb 25, 2025

View reviewed changes

packages/lib-sourcify/test/Verification/Verification.spec.ts Outdated Show resolved Hide resolved

Improve source file reading and verification error handling

a1f85fe

- Update source file reading to support nested directory structures - Clarify error message for bytecode matching with no auxdata - Improve test description for bytecode matching scenario

kuzdogan approved these changes Feb 26, 2025

View reviewed changes

marcocastignoli merged commit 337fd91 into verification-flow-refactoring-main Feb 26, 2025
6 checks passed

marcocastignoli deleted the verification-flow-verification-classes branch February 26, 2025 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Verification flow verification classes #1879

Verification flow verification classes #1879

marcocastignoli commented Jan 30, 2025 •

edited

Loading

manuelwedler left a comment

marcocastignoli commented Feb 11, 2025

marcocastignoli commented Feb 13, 2025 •

edited

Loading

kuzdogan left a comment

kuzdogan left a comment

kuzdogan left a comment

Verification flow verification classes #1879

Verification flow verification classes #1879

Conversation

marcocastignoli commented Jan 30, 2025 • edited Loading

manuelwedler left a comment

Choose a reason for hiding this comment

marcocastignoli commented Feb 11, 2025

marcocastignoli commented Feb 13, 2025 • edited Loading

kuzdogan left a comment

Choose a reason for hiding this comment

kuzdogan left a comment

Choose a reason for hiding this comment

kuzdogan left a comment

Choose a reason for hiding this comment

marcocastignoli commented Jan 30, 2025 •

edited

Loading

marcocastignoli commented Feb 13, 2025 •

edited

Loading