Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GenericErrorResponse for all errors returned from /v2 #1946

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

manuelwedler
Copy link
Contributor

Closes #1855

This maps the following errors to the new format:

  • openapi validator errors
  • route not found errors
  • unknown / uncaught errors

Also refactors some of the v1 code to the v1 folder in order to reduce the server.ts file.

This maps the following errors to the new format:
- openapi validator errors
- route not found errors
- unknown / uncaught errors
Copy link
Member

@marcocastignoli marcocastignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this refactoring, just a couple minor questions

Copy link
Member

@marcocastignoli marcocastignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manuelwedler manuelwedler merged commit db04ab0 into staging Feb 24, 2025
6 checks passed
@manuelwedler manuelwedler deleted the apiv2-error-handling branch February 24, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

Implement GenericErrorResponse interface for all errors returned from /v2
2 participants