Skip to content

Track when the stack trace symbolication succeeds #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025

Conversation

vzaidman
Copy link

@vzaidman vzaidman commented Jul 1, 2025

Summary

Added a tracking to when Hermes specific parsing of stack traces occurs.

Test plan

See D77593141

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@vzaidman vzaidman force-pushed the track-special-strack-trace-symbolications branch 4 times, most recently from 9553dcb to 4494278 Compare July 3, 2025 13:27
@vzaidman vzaidman changed the title Track when a special stack trace symbolication occurs Track when the stack trace symbolication succeeds Jul 4, 2025
@vzaidman vzaidman force-pushed the track-special-strack-trace-symbolications branch from 4494278 to af3a394 Compare July 7, 2025 15:24
@vzaidman vzaidman requested review from motiz88 and hoxyq July 7, 2025 15:25
@vzaidman vzaidman force-pushed the track-special-strack-trace-symbolications branch from af3a394 to f516628 Compare July 8, 2025 08:47
@vzaidman vzaidman merged commit 844f225 into main Jul 8, 2025
5 checks passed
@vzaidman vzaidman deleted the track-special-strack-trace-symbolications branch July 8, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants