feat: add concurrency_buffer to protobufs #440
Merged
+99
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step in exposing with fal app list, and allowing to adjust with fal app scale
cmlad
commented
Mar 10, 2025
| @@ -62,6 +61,6 @@ class HealthCheckResponse(google.protobuf.message.Message): | |||
| *, | |||
| status: global___HealthCheckResponse.ServingStatus.ValueType = ..., | |||
| ) -> None: ... | |||
| def ClearField(self, field_name: typing.Literal["status", b"status"]) -> None: ... | |||
| def ClearField(self, field_name: typing_extensions.Literal["status", b"status"]) -> None: ... | |||
There was a problem hiding this comment.
these changes are due to the mypy-protobuf version fix, bringing this file in line with the others that use the typing_extensions decorators
chamini2
approved these changes
Mar 10, 2025
| @@ -37,5 +37,5 @@ dev = [ | |||
| # for tools/regen_grpc.py | |||
| "refactor", | |||
| "grpcio-tools==1.64.0", | |||
| "mypy-protobuf", | |||
| "mypy-protobuf==3.5.0", | |||
There was a problem hiding this comment.
@efiop can you confirm if doing this is fine?
efiop
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in exposing with fal app list, and allowing to adjust with fal app scale
Also:
mypy-protobufto prior version3.5.0so we don't get a massive diff. If we want to update, we should do a separate clean PR with the version bump and the code update.