Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add concurrency_buffer to protobufs #440

Merged
merged 1 commit into from
Mar 11, 2025
+99 −76
Merged

feat: add concurrency_buffer to protobufs #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/isolate_proto/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ dev = [
# for tools/regen_grpc.py
"refactor",
"grpcio-tools==1.64.0",
"mypy-protobuf",
"mypy-protobuf==3.5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efiop can you confirm if doing this is fine?

]
4 changes: 4 additions & 0 deletions projects/isolate_proto/src/isolate_proto/controller.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ message MachineRequirements {
optional int32 num_gpus = 12;
optional int32 request_timeout = 13;
optional int32 startup_timeout = 14;
optional int32 concurrency_buffer = 15;
}

enum ApplicationAuthMode {
Expand Down Expand Up @@ -213,6 +214,7 @@ message UpdateApplicationRequest {
repeated string machine_types = 7;
optional int32 request_timeout = 8;
optional int32 startup_timeout = 9;
optional int32 concurrency_buffer = 10;
}

message UpdateApplicationResult {
Expand All @@ -234,6 +236,7 @@ message ApplicationInfo {
optional int32 request_timeout = 9;
optional int32 startup_timeout = 10;
repeated string valid_regions = 11;
optional int32 concurrency_buffer = 12;
}

message ListApplicationsResult {
Expand Down Expand Up @@ -287,6 +290,7 @@ message AliasInfo {
optional int32 request_timeout = 10;
optional int32 startup_timeout = 11;
repeated string valid_regions = 12;
optional int32 concurrency_buffer = 13;
}

message SetSecretRequest {
Expand Down
Loading