Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport Graphs #5

Merged
merged 3 commits into from
Jul 4, 2016
Merged

Transport Graphs #5

merged 3 commits into from
Jul 4, 2016

Conversation

WardCunningham
Copy link
Member

This experimental version supports transporting graph-source from the equally experimental Graph plugin under development with @opn. github, comment.

A GRAPH option in the markup offers to send parsed graph data rather than waiting for a drop.

image

This pull request is safe to merge but unfinished. Expect improvements soon.

@WardCunningham
Copy link
Member Author

I will note here a strange bug I found while debugging this.

The 'graph-source' protocol expects graph sourcing items to provide a function that returns a parsed graph. This worked fine until I added a parse function here returning the parsed transport options. The two versions of parse collided. Once I understood this, I renamed the option parser to 'options'.

This needs a better solution. A Graph should find its parse in the scope of its definition, not that of the caller. Surely there is some way to add one more layer of wrapper functions to make this so. Or maybe proper this binding, or prototypes, or ES6 classes provide the right stuff.

@WardCunningham
Copy link
Member Author

I will merge and publish this and #4 as version 0.0.8.

@WardCunningham WardCunningham merged commit 480df2c into master Jul 4, 2016
@paul90 paul90 deleted the ward/graph branch July 17, 2016 14:44
@paul90 paul90 mentioned this pull request Jul 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant