-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a sysext for vim-huge #78
base: main
Are you sure you want to change the base?
Conversation
There are several cases when the user needs to edit k8s yamls inplace directly on the master nodes and having syntax highlighting and advanced formatting of vim available is a nice feature since the default vim of flatcar have those disabled.
We have just discussed whether we might want to leverage existing Gentoo packages for this instead. We could potentially do this in such a way that avoids dependence on system libraries (besides glibc) either by still statically linking or by placing the dynamic libraries within the sysext. I could look into this soon, but I don't mind accepting this in the interim. |
Hi @chewi , will this be accepted? |
I have no objections, but I'd want someone else to look over it. I'm not familiar with sysext building yet. |
FYI, the build process of the extensions in this repo is supposed to be fast, avoiding compilation if we can (that's the reason one build recipe was not included in the official repo releases so far). That said, I'm not reviewing things here now and someone else has to decide what to do with this PR. |
IMHO sysext should not be considered as the next package manager, so perhaps vim as an editor that exists in every linux distribution might not fit here. just sharing my point of view, no harm :) |
@pothos @xinity Do you have a resolution for this? Would @jsalatiel PR be accepted? |
well i'm not a sysext-bakery maintainer so my opinion worth almost nothing :) TLDR: before accepting or rejecting any PR , perhaps maintainers should think about guidelines, clear targets and expections. Again i'm nobody to tell anyone what they should do, i'm just sharing my very personal point of view. |
There are several cases when the user needs to edit k8s yamls inplace directly on the master nodes and having syntax highlighting and advanced formatting of vim available is a nice feature since the default vim of flatcar have those disabled.