Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Headlamp article as a resource #2096

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Add the Headlamp article as a resource #2096

merged 1 commit into from
Nov 25, 2024

Conversation

kingdonb
Copy link
Member

@kingdonb kingdonb commented Nov 24, 2024

There were a few articles hosted on weave.works but they are not accessible anymore, so had to be removed.

I am testing this feature to be sure I know how it works, since we do not have any live examples today!

(I'd like to add this one too:)

@kingdonb
Copy link
Member Author

kingdonb commented Nov 24, 2024

We need to add thumbnails and/or description text in order to use this feature effectively. I wonder if there is a streamlined way to do this.

(You can see how it looks without any thumbnail here: https://deploy-preview-2096--fluxcd.netlify.app/resources/)

An example from when this feature was implemented is here: d4224e9

Probably can find a thumbnail asset on either site, (there may be a reference in the RSS feed)

@@ -13,6 +13,11 @@ resources:
# Note: To generate "thumbnail_url", visit https://embed.ly/docs/explore/extract
# and enter the link to the resource. Once you do that, select any thumbnail url of choice to use.

- url: https://headlamp.dev/blog/2024/11/07/flux-ui/
title: "From ClickOps to GitOps: A new Flux UI"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add "Headlamp blog" or something that hints this is about Headlamp?

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kingdonb

@kingdonb kingdonb marked this pull request as ready for review November 25, 2024 18:36
@kingdonb kingdonb added area/resources Video resources related issues and pull requests backport:v2-4 To be backported to v2-4 area/ecosystem Ecosystem related issues and pull requests labels Nov 25, 2024
* add a thumbnail url
* say "Headlamp Blog"

Signed-off-by: Kingdon Barrett <[email protected]>
@kingdonb kingdonb force-pushed the headlamp-ui-article branch from 530ef13 to eb9bdb6 Compare November 25, 2024 18:39
@kingdonb kingdonb merged commit 52353ee into main Nov 25, 2024
5 checks passed
@kingdonb kingdonb deleted the headlamp-ui-article branch November 25, 2024 18:42
@fluxcdbot
Copy link
Member

Successfully created backport PR for v2-4:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ecosystem Ecosystem related issues and pull requests area/resources Video resources related issues and pull requests backport:v2-4 To be backported to v2-4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants