Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: category dropdown #117

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: category dropdown #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions common/common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,9 +825,17 @@ div.select-kit-header {
background-color: $fcc-d-hover;
}

// Dropdown items
// Dropdown
.select-kit-header {
color: $fcc-primary-color $i;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to correct the text color when the dropdown button is at rest.

}

.select-kit-header:hover,
.select-kit.is-expanded .select-kit-header,
.select-kit-row.is-highlighted,
.select-kit-row.is-selected, {
.select-kit-row.is-selected,
.select-kit-row.is-highlighted a,
.select-kit-row.is-highlighted span {
background-color: $primary $i;
color: $fcc-quaternary-background $i;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my code from a previous PR. I figured using a background color token for text color is weird, so I changed it to primary-low.

This is essentially a change in the gray scale and slightly increases the contrast of the text against the background.

color: $primary-low $i;
}
Loading