Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: category dropdown #117

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

huyenltnguyen
Copy link
Member

Checklist:

Fixes a couple of issues in the Category dropdown:

  • The dropdown color is lighter than the rest of the buttons.
    • Screenshot 2024-03-19 at 14 14 32
  • Dropdown items text doesn't have sufficient contrast against the background.
    • Screenshot 2024-03-19 at 15 11 56

Results

Screenshots

At rest

Theme Screenshot
Day Screenshot 2024-03-19 at 23 31 16
Dawn Screenshot 2024-03-19 at 23 33 24
Night Screenshot 2024-03-19 at 23 32 41

Expanded and hovered

Theme Screenshot
Day Screenshot 2024-03-19 at 14 09 44
Dawn Screenshot 2024-03-19 at 14 10 41
Night Screenshot 2024-03-19 at 14 10 14

background-color: $primary $i;
color: $fcc-quaternary-background $i;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my code from a previous PR. I figured using a background color token for text color is weird, so I changed it to primary-low.

This is essentially a change in the gray scale and slightly increases the contrast of the text against the background.

// Dropdown items
// Dropdown
.select-kit-header {
color: $fcc-primary-color $i;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to correct the text color when the dropdown button is at rest.

@huyenltnguyen huyenltnguyen marked this pull request as ready for review March 19, 2024 16:52
@huyenltnguyen huyenltnguyen requested a review from a team as a code owner March 19, 2024 16:52
@raisedadead raisedadead merged commit ed78804 into freeCodeCamp:main Apr 23, 2024
1 check passed
@huyenltnguyen huyenltnguyen deleted the fix/category-dropdown branch April 23, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants