Update header implementation for upcoming Discourse changes #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discourse will soon be dropping the 'widget' system for rendering its header. This commit switches the theme from the deprecated APIs to the their modern equivalents. As a nice side effect, this also fixes the layout issue of the 'visit the curriculum' button for anonymous users. More information on the changes can be found at https://meta.discourse.org/t/296544
|
Thank you for taking the time to update this. I might be incorrectly testing this, but this is what I see:
The header button is still too far up (on Chrome) |
Previously it was being rendered as a button on the right hand side of the header, and then `position:fixed` was used to pull it to the left. This made for some weird rendering quirks. This commit uses a plugin outlet to render it in the correct part of the HTML, which removes the need for the positioning workarounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #116
Discourse will soon be dropping the 'widget' system for rendering its header. This commit switches the theme from the deprecated APIs to the their modern equivalents. As a nice side effect, this also fixes the layout issue of the 'visit the curriculum' button for anonymous users.
More information on the changes can be found at https://meta.discourse.org/t/296544
Before:
After:
