Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update header implementation for upcoming Discourse changes #120

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Update header implementation for upcoming Discourse changes #120

merged 2 commits into from
Apr 12, 2024

Commits on Apr 11, 2024

  1. Update header implementation for upcoming Discourse changes 

    Discourse will soon be dropping the 'widget' system for rendering its header. This commit switches the theme from the deprecated APIs to the their modern equivalents. As a nice side effect, this also fixes the layout issue of the 'visit the curriculum' button for anonymous users.

More information on the changes can be found at https://meta.discourse.org/t/296544
    @davidtaylorhq
    davidtaylorhq committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    e5e6164 View commit details
    Browse the repository at this point in the history

  2. Move curriculum-nav to before-header-panel to avoid positioning hacks 

    Previously it was being rendered as a button on the right hand side of the header, and then `position:fixed` was used to pull it to the left. This made for some weird rendering quirks. This commit uses a plugin outlet to render it in the correct part of the HTML, which removes the need for the positioning workarounds.
    @davidtaylorhq
    davidtaylorhq committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    7539991 View commit details
    Browse the repository at this point in the history