FIX: Increase header icon rule specificity #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A side effect of the recent header upgrade was to introduce the `.btn` class on the header buttons. That means they are now subject to the `color: inherit` rule on line 557 of this theme's css. This commit increases the specificity of the header icon selector so that it 'wins' over the more general `color: inherit` rule. This should fix the icon color problems under the 'day' theme on freecodecamp.
|
Hey @davidtaylorhq thanks a lot for these fixes, we at freeCodeCamp appreciate everything you all at Discourse do for us 🙌 - Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A side effect of the recent header upgrade was to introduce the
.btnclass on the header buttons. That means they are now subject to thecolor: inheritrule on line 557 of this theme's css.This commit increases the specificity of the header icon selector so that it 'wins' over the more general
color: inheritrule.This should fix the icon color problems under the 'day' theme on freecodecamp.
Checklist:
Update index.md)Closes #XXXXX